Skip to content

Vertoz Adapter#789

Merged
jaiminpanchal27 merged 3 commits into
prebid:masterfrom
Prebid-Vertoz:master
Nov 16, 2016
Merged

Vertoz Adapter#789
jaiminpanchal27 merged 3 commits into
prebid:masterfrom
Prebid-Vertoz:master

Conversation

@Prebid-Vertoz

@Prebid-Vertoz Prebid-Vertoz commented Nov 14, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Type of change

  • New bidder adapter

Description of change

  Added Vertoz adapter
  • test parameters for validating bids
{
  bidder: 'vertoz',
  params: {
        placementId:'VZH123'      //REQUIRED AD unit id
  }
}

Other information

@jaiminpanchal27

  • Added bid object as second parameter in createBid call.
  • Use of constants defined in constants.json.
  • Removed extra lines from vertoz_spec.js.
  • Fixed endpoint access to global.

@jaiminpanchal27 jaiminpanchal27 self-assigned this Nov 14, 2016
jaiminpanchal27
jaiminpanchal27 requested changes Nov 16, 2016
View reviewed changes

@jaiminpanchal27 jaiminpanchal27 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Prebid-Vertoz
I am getting the ad response now.
Please check the comments and update.

Comment thread src/adapters/vertoz.js Outdated
for (var i = 0; i < bids.length; i++) {

var bid = bids[i];

@jaiminpanchal27 jaiminpanchal27 Nov 16, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line

Comment thread src/adapters/vertoz.js Outdated
var bid = bids[i];

let slotBidId = utils.getValue(bid,'bidId');

@jaiminpanchal27 jaiminpanchal27 Nov 16, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line

Comment thread src/adapters/vertoz.js Outdated
let slotBidId = utils.getValue(bid,'bidId');

let cb = Math.round(new Date().getTime() / 1000);

@jaiminpanchal27 jaiminpanchal27 Nov 16, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line

Comment thread src/adapters/vertoz.js Outdated
let cb = Math.round(new Date().getTime() / 1000);

let vzEndPoint = BASE_URI;

@jaiminpanchal27 jaiminpanchal27 Nov 16, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line

Comment thread src/adapters/vertoz.js Outdated
let vzEndPoint = BASE_URI;

let reqParams = bid.params || {};

@jaiminpanchal27 jaiminpanchal27 Nov 16, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line

Comment thread src/adapters/vertoz.js Outdated
bidObject.ad = bidRespObj.ad + utils.createTrackPixelHtml(decodeURIComponent(bidRespObj.nurl));
bidObject.width = bidRespObj.adWidth;
bidObject.height = bidRespObj.adHeight;

@jaiminpanchal27 jaiminpanchal27 Nov 16, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line

Comment thread src/adapters/vertoz.js Outdated

}
else {

@jaiminpanchal27 jaiminpanchal27 Nov 16, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line

Comment thread src/adapters/vertoz.js Outdated
bidObject.height = bidRespObj.adHeight;

}
else {

@jaiminpanchal27 jaiminpanchal27 Nov 16, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if else should be like, here else is not in proper line.

if {
//Code
} else {
//Code
}

Comment thread test/spec/adapters/vertoz_spec.js Outdated
let vzBidRequest;

let bidderReponse = {

@jaiminpanchal27 jaiminpanchal27 Nov 16, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line

Comment thread test/spec/adapters/vertoz_spec.js

let firstBidReg;
let adSpaceId;

@jaiminpanchal27 jaiminpanchal27 Nov 16, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line

@Nilesh5

Nilesh5 commented Nov 16, 2016

Copy link
Copy Markdown

@jaiminpanchal27
Hello Jaimin,
I understood the changes and have edited accordingly.
Please review the changes.
Thank You.

@jaiminpanchal27

jaiminpanchal27 commented Nov 16, 2016

Copy link
Copy Markdown
Collaborator

Thanks @Prebid-Vertoz
Looks good. Merging

@jaiminpanchal27
jaiminpanchal27 merged commit 3ba675d into prebid:master Nov 16, 2016
@mkendall07

mkendall07 commented Nov 17, 2016

Copy link
Copy Markdown
Contributor

@Prebid-Vertoz
Please submit a docs PR here: https://github.com/prebid/prebid.github.io/tree/master/dev-docs/bidders

@Nilesh5

Nilesh5 commented Nov 17, 2016

Copy link
Copy Markdown

@mkendall07
Yes sure,Matt.
Will do it soon.

mp-12301 pushed a commit to AOL-archive/Prebid.js that referenced this pull request Apr 10, 2017
Merge pull request prebid#55 in AOLP_ADS_JS/prebid.js from feature/Pr…
4f6762b 
…ebid-0.15.2 to release/1.8.0

* commit '3c3d298eb248a7f69dd4ae86f3f6341f2c04b1b5': (36 commits)
  CHANGELOG
  Add new adapters for AOL analytics.
  Prebid 0.15.2 Release
  Fix issue with building prebid from npm install. Babel loader was being skipped because of the project residing in /node_modules/ directory. (prebid#820)
  Increment pre version
  Prebid 0.15.1 Release
  Update bidFloor->bidfloor to match other bidders + updated conversant docs (prebid#818)
  Correct 'bidloor' typo in Conversant adapter (prebid#815)
  Increment pre version
  0.15.0 release
  support IE userLanguage Navigator property (prebid#807)
  exclude node_modules from babel-loader as to prevent strict mode errors (prebid#806)
  PulsePoint Adapter - Support for additional parameters. (prebid#784)
  Fix 'skippable' targeting typo (prebid#804)
  Adding adKernel adapter (prebid#739)
  Babel plugin fixes to make the generated code syntax valid in ie8 (prebid#799)
  Vertoz Adapter (prebid#789)
  RubiconLite is now just Rubicon and "rubicon" aliases "rubiconLite" (prebid#783)
  add version to global namespace (prebid#794)
  Adform adapter tests fixed prebid#769 (prebid#793)
  ...
mp-12301 pushed a commit to AOL-archive/Prebid.js that referenced this pull request Apr 10, 2017
Merge pull request prebid#58 in AOLP_ADS_JS/prebid.js from release/1.…
c0b731f 
…8.0 to master

* commit '997aa5bce17aafd6b215d335551e89757f92bf3e': (37 commits)
  CHANGELOG.
  CHANGELOG
  Add new adapters for AOL analytics.
  Prebid 0.15.2 Release
  Fix issue with building prebid from npm install. Babel loader was being skipped because of the project residing in /node_modules/ directory. (prebid#820)
  Increment pre version
  Prebid 0.15.1 Release
  Update bidFloor->bidfloor to match other bidders + updated conversant docs (prebid#818)
  Correct 'bidloor' typo in Conversant adapter (prebid#815)
  Increment pre version
  0.15.0 release
  support IE userLanguage Navigator property (prebid#807)
  exclude node_modules from babel-loader as to prevent strict mode errors (prebid#806)
  PulsePoint Adapter - Support for additional parameters. (prebid#784)
  Fix 'skippable' targeting typo (prebid#804)
  Adding adKernel adapter (prebid#739)
  Babel plugin fixes to make the generated code syntax valid in ie8 (prebid#799)
  Vertoz Adapter (prebid#789)
  RubiconLite is now just Rubicon and "rubicon" aliases "rubiconLite" (prebid#783)
  add version to global namespace (prebid#794)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

Assignees

@jaiminpanchal27 jaiminpanchal27

Labels

needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Prebid-Vertoz @Nilesh5 @jaiminpanchal27 @mkendall07