Skip to content

Timeout RTD Provider & Insticator & Sharethrough Bid Adapter: bug fixes for imports #7424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisHuie merged 7 commits into from
Sep 16, 2021
Merged

Timeout RTD Provider & Insticator & Sharethrough Bid Adapter: bug fixes for imports #7424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
67b1fce
Update timeoutRtdProvider.js
patmmccann Sep 16, 2021
7f5d7dd
Update timeoutRtdProvider.js
patmmccann Sep 16, 2021
2c226dc
Update timeoutRtdProvider.js
patmmccann Sep 16, 2021
5d59370
Update sharethroughBidAdapter.js
patmmccann Sep 16, 2021
570b095
Update sharethroughBidAdapter.js
patmmccann Sep 16, 2021
628ff6f
Update sharethroughBidAdapter.js
patmmccann Sep 16, 2021
d2ed2e2
Update insticatorBidAdapter.js
patmmccann Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/insticatorBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
logError,
} from '../src/utils.js';
import { getStorageManager } from '../src/storageManager.js';
import find from 'core-js-pure/features/array/find.js';

const BIDDER_CODE = 'insticator';
const ENDPOINT = 'https://ex.ingage.tech/v1/openrtb'; // production endpoint
Expand Down Expand Up @@ -151,7 +152,7 @@ function buildRequest(validBidRequests, bidderRequest) {
}

function buildBid(bid, bidderRequest) {
const originalBid = bidderRequest.bids.find((b) => b.bidId === bid.impid);
const originalBid = find(bidderRequest.bids, (b) => b.bidId === bid.impid);

return {
requestId: bid.impid,
Expand Down
3 changes: 2 additions & 1 deletion modules/sharethroughBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import * as utils from '../src/utils.js';
import { config } from '../src/config.js';
import { BANNER, VIDEO } from '../src/mediaTypes.js';
import { createEidsArray } from './userId/eids.js';
import find from 'core-js-pure/features/array/find.js';

const VERSION = '4.0.0';
const BIDDER_CODE = 'sharethrough';
Expand Down Expand Up @@ -270,7 +271,7 @@ function getProtocol() {
}

function matchRequest(id, request) {
return request.bidRequests.find(bid => bid.bidId === id);
return find(request.bidRequests, bid => bid.bidId === id);
}

// stub for ?? operator
Expand Down
10 changes: 9 additions & 1 deletion modules/timeoutRtdProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,14 @@ export const timeoutRtdFunctions = {
handleTimeoutIncrement
};

const entries = Object.entries || function(obj) {
const ownProps = Object.keys(obj);
let i = ownProps.length;
let resArray = new Array(i);
while (i--) { resArray[i] = [ownProps[i], obj[ownProps[i]]]; }
return resArray;
};

function getDeviceType() {
const userAgent = window.navigator.userAgent.toLowerCase();
if ((/ipad|android 3.0|xoom|sch-i800|playbook|tablet|kindle/i.test(userAgent))) {
Expand Down Expand Up @@ -78,7 +86,7 @@ function calculateTimeoutModifier(adUnits, rules) {
if (rules.numAdUnits[numAdUnits]) {
timeoutModifier += rules.numAdUnits[numAdUnits];
} else {
for (const [rangeStr, timeoutVal] of Object.entries(rules.numAdUnits)) {
for (const [rangeStr, timeoutVal] of entries(rules.numAdUnits)) {
const [lowerBound, upperBound] = rangeStr.split('-');
if (parseInt(lowerBound) <= numAdUnits && numAdUnits <= parseInt(upperBound)) {
utils.logInfo(`Adding ${timeoutVal} to timeout for numAdUnits ${numAdUnits}`)
Expand Down