Skip to content

VIS.X Bid Adapter: fix handling of bid response #7233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisHuie merged 3 commits into from
Jul 29, 2021
Merged

VIS.X Bid Adapter: fix handling of bid response #7233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4cc931
VIS.X: add failing test
Jul 29, 2021
fcc2315
VIS.X: additional check for instream video
Jul 29, 2021
4a0a0d4
VIS.X: missing semicolon
Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions modules/visxBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ function _addBidResponse(serverBid, bidsMap, currency, bidResponses, bidsWithout
bidResponse.ext = serverBid.ext.prebid;
}

if (!_isVideoBid(bid)) {
if (!_isVideoInstreamBid(bid)) {
bidResponse.ad = serverBid.adm;
} else {
bidResponse.vastXml = serverBid.adm;
Expand Down Expand Up @@ -298,14 +298,18 @@ function _isVideoBid(bid) {
return bid.mediaType === VIDEO || deepAccess(bid, 'mediaTypes.video');
}

function _isVideoInstreamBid(bid) {
return _isVideoBid(bid) && deepAccess(bid, 'mediaTypes.video', {}).context === VIDEO_INSTREAM;
}

function _isBannerBid(bid) {
return bid.mediaType === BANNER || deepAccess(bid, 'mediaTypes.banner');
}

function _isValidVideoBid(bid, logErrors = false) {
let result = true;
const videoMediaType = deepAccess(bid, 'mediaTypes.video');
if (videoMediaType.context !== VIDEO_INSTREAM) {
if (!_isVideoInstreamBid(bid)) {
if (logErrors) {
logError(LOG_ERROR_MESS.onlyVideoInstream);
}
Expand Down
51 changes: 51 additions & 0 deletions test/spec/modules/visxBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,57 @@ describe('VisxAdapter', function () {
expect(result).to.deep.equal(expectedResponse);
});

it('handles multiformat bid response with outstream+banner as banner', function () {
const fullResponse = [
{'bid': [{'price': 0.5, 'adm': '<VAST/>', 'auid': 903537, 'w': 400, 'h': 300, 'cur': 'EUR', 'mediaType': 'video'}], 'seat': '1'},
];
const bidRequests = [
{
'bidder': 'visx',
'params': {
'uid': '903537'
},
'adUnitCode': 'adunit-code-1',
'mediaTypes': {
'video': {
'context': 'outstream',
'playerSize': [400, 300],
'mimes': ['video/mp4'],
'protocols': [3, 6]
}
},
'banner': {
'sizes': []
},
'sizes': [[400, 300]],
'bidId': '2164be6358b9',
'bidderRequestId': '106efe3247',
'auctionId': '32a1f276cb87cb8',
}
];
const request = spec.buildRequests(bidRequests);
const expectedResponse = [
{
'ad': '<VAST/>',
'requestId': '2164be6358b9',
'cpm': 0.5,
'creativeId': 903537,
'dealId': undefined,
'width': 400,
'height': 300,
'currency': 'EUR',
'netRevenue': true,
'ttl': 360,
'meta': {
'advertiserDomains': [],
'mediaType': 'video',
},
}
];
const result = spec.interpretResponse({'body': {'seatbid': fullResponse}}, request);
expect(result).to.deep.equal(expectedResponse);
});

it('should get right ext data in bid response', function () {
const bidRequests = [
{
Expand Down