Fix for userId_example.html - #5606
Merged
Merged
Conversation
fix userId_example.html
jlukas79
approved these changes
Aug 17, 2020
Contributor
Author
|
Hi @jlukas79, can we merge this pr? |
Collaborator
|
this example page is now broken because it relies on tcf 1 which is no longer supported by the IAB, so the vendorlist.json is failing to load. this is a problem with the other examples, too, though, so that should be corrected separately. i'll go ahead and merge this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
On running
gulp serveand navigating to integrationExamples/gpt/userId_example.html?pbjs_debug=true, one can see prebid initialised but the bids are not generated.Issue arises due to:-
mediaTypesconfiguration in adUnit (test-div).usersyncinstead ofuserSyncpresent in setConfig method.Fixes of these both are available in this pr and results in correct behaviour in terms of userIds in
pbjs.getUserIds()and bids inpbjs.adUnits.Find the attached console output which shows the error

.