Skip to content

New e-volution tech bid adapter - #4934

Merged
msm0504 merged 14 commits into
prebid:masterfrom
e-volution-tech:master
Mar 17, 2020
Merged

New e-volution tech bid adapter#4934
msm0504 merged 14 commits into
prebid:masterfrom
e-volution-tech:master

Conversation

@e-volution-tech

@e-volution-tech e-volution-tech commented Mar 5, 2020

Copy link
Copy Markdown
Contributor

Type of change

  • New bidder adapter

Description of change

  • test parameters for validating bids
{
  bidder: 'e_volution',
  params: {
    placementId: 0,
    traffic: 'video'
  }
}
{
  bidder: 'e_volution',
  params: {
  placementId: 0,
    traffic: 'banner',
  }
}

@harpere
harpere requested a review from msm0504 March 5, 2020 22:17
@e-volution-tech

e-volution-tech commented Mar 10, 2020

Copy link
Copy Markdown
Contributor Author

prebid/prebid.github.io#1839 Docs are waiting to be merged

msm0504
msm0504 suggested changes Mar 11, 2020
View reviewed changes
Comment thread modules/evolution_techBidAdapter.js Outdated
Comment thread modules/evolution_techBidAdapter.js Outdated
Comment thread modules/evolution_techBidAdapter.js Outdated
Comment thread modules/evolution_techBidAdapter.js Outdated
Comment thread modules/evolution_techBidAdapter.js
Comment thread modules/evolution_techBidAdapter.md
@e-volution-tech

e-volution-tech commented Mar 12, 2020

Copy link
Copy Markdown
Contributor Author

@msm0504 Thanks for your comments, i've made all changes according to them

msm0504
msm0504 approved these changes Mar 17, 2020
View reviewed changes

@msm0504 msm0504 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msm0504 msm0504 added the LGTM label Mar 17, 2020
@msm0504
msm0504 merged commit 1034f27 into prebid:master Mar 17, 2020
@bretg bretg mentioned this pull request Apr 1, 2020
Merged
1 task
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
@e-volution-tech @rjvelicaria
New e-volution tech bid adapter (prebid#4934)
23c3c7f 
* initial

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fixes

* navigator check

* navigator.language check
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
@e-volution-tech Sverre
New e-volution tech bid adapter (prebid#4934)
568db32 
* initial

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fixes

* navigator check

* navigator.language check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@msm0504 msm0504 msm0504 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@msm0504 msm0504

Labels

LGTM needs docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@e-volution-tech @msm0504 @harpere