Skip to content

Trion gdpr and usp consent - #4740

Merged
bretg merged 26 commits into
prebid:masterfrom
grohm33:master
Jan 21, 2020
Merged

Trion gdpr and usp consent#4740
bretg merged 26 commits into
prebid:masterfrom
grohm33:master

Conversation

@grohm33

@grohm33 grohm33 commented Jan 16, 2020

Copy link
Copy Markdown
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Updating Trion to comply with gdpr and usp consent

Mike Groh and others added 25 commits October 17, 2017 18:20
…that we didn't account for. Changing adapter to account for response body and required params.
…release that we didn't account for. Changing adapter to account for response body and required params."

This reverts commit 324d157.
…that we didn't account for. Changing adapter to account for response body and required params.
# Conflicts:
#	modules/trionBidAdapter.js
#	test/spec/modules/trionBidAdapter_spec.js
@grohm33

grohm33 commented Jan 16, 2020

Copy link
Copy Markdown
Contributor Author

also submitted documentation pull request at prebid/prebid.github.io#1752

@bretg bretg added the LGTM label Jan 16, 2020
@bretg

bretg commented Jan 16, 2020

Copy link
Copy Markdown
Contributor

LGTM, but please try re-running the CircleCI unit tests to get them to pass.

@bretg bretg self-assigned this Jan 16, 2020
@grohm33

grohm33 commented Jan 16, 2020

Copy link
Copy Markdown
Contributor Author

LGTM, but please try re-running the CircleCI unit tests to get them to pass.

@bretg we had this issue with circleci build checks not passing on here in the past with our pull requests. We do not have a browser stack account to run this against so the error I'm getting in the build is 'Username is required'.

@bretg

bretg commented Jan 21, 2020

Copy link
Copy Markdown
Contributor

I opened a CircleCI support ticket to get to the bottom of why some PRs (like this one) end up outside of Prebid's CircleCI account.

The response was:

It's likely that the users in questions are following their own project on our end, rather than the
open-source project - this will cause builds to trigger under their account rather than yours.
Asking the users to unfollow the project under their account in CircleCI and instead follow the
"real" project should resolve this issue.

On your CircleCI project's screen, click "unfollow" on the Prebid.js row for your fork:

Screen Shot 2020-01-21 at 9 25 12 AM

@grohm33

grohm33 commented Jan 21, 2020

Copy link
Copy Markdown
Contributor Author

@bretg Thanks for the info! I didn't realize it was associating our fork to the circleCi project. The tests all pass now.

@bretg
bretg merged commit 1373313 into prebid:master Jan 21, 2020
@mkendall07 mkendall07 mentioned this pull request Apr 27, 2020
1 task
@musikele musikele mentioned this pull request May 27, 2020
1 task
@harpere harpere mentioned this pull request Sep 25, 2020
2 tasks
@ericrenebrown

Copy link
Copy Markdown
Contributor

This is happening to me. Stopped following but I can't see an option to follow the "real" project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants