Export IntrinsicHTMLElements interface#4885
Merged
rschristian merged 1 commit intopreactjs:mainfrom Aug 14, 2025
Merged
Conversation
Member
Which issues are those exactly? |
rschristian
approved these changes
Aug 14, 2025
Member
rschristian
left a comment
There was a problem hiding this comment.
I don't see much harm in it, even if it's rather niche & has some footguns for those that choose to use it (HTMLDetailsAttributes, for example, no longer aligns with the JSX type in your example above).
We probably wouldn't document an example like that so IMO it's fine.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces and exports the
IntrinsicHTMLElementsinterface, which is extended byIntrinsicElements. This approach allows you to declare built-in custom elements without running into interface merging issues.Example: