Check git mode on Windows#480
Merged
asottile merged 1 commit intopre-commit:masterfrom May 18, 2020
mxr:git-file-mode
Merged
Conversation
Member
Author
|
@asottile I can't request a review in the GitHub UI but this should be ready for review now |
asottile
approved these changes
May 18, 2020
Member
asottile
left a comment
asottile
left a comment
There was a problem hiding this comment.
sweet, I improved this on stream! added a few tests and made sure things worked well on windows
Member
Author
|
Awesome! |
mxr
commented
May 19, 2020
|
|
||
| f = tmpdir.join('f') | ||
| f.write('#!/usr/bin/env bash') | ||
| f_path = str(f) |
Member
Author
There was a problem hiding this comment.
The other tests use .strpath, is one preferred over the other?
Member
There was a problem hiding this comment.
apparently strpath is not documented despite being a public attribute so I've mostly switched to str(...) now that I don't care about python2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #435