Pre release range fix#40
Merged
Merged
Conversation
Some of which currently fail
E.g. a version '1.0.0-beta' was not selected by a range define like '1.x'
Owner
|
Sorry for late response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request fixes a bunch of issues with 'range checks'. It therefore adds several tests along with a proposed fix.
I compared the behavior with node-semver and by this PR, we'd come much closer to its behavior.
I'm not sure how the version of this Python module should be handled: While it's a bugfix, it certainly may affect existing software out there... such as Conan packages. Therefore, an increase in major should be considered.
See also the issue /issues/37