PY-53: Wartezeit nach "Start Development"

[kaesetoast]

Task

PY-53: Wartezeit nach "Start Development"

Summary

Summary by CodeRabbit

• New Features

  • Added visible "Creating branch…" and "Starting…" loading states during development setup
  • Repository selector and start buttons are disabled while setup is in progress
  • Checkout command is automatically copied to clipboard on successful setup
  • Improved success/error notifications for development initialization actions

• Accessibility

  • Setup panel signals busy state to assistive technologies (aria-busy)

[netlify]

✅ Deploy Preview for pno-project-y ready!

Name	Link
🔨 Latest commit	ffe27ea
🔍 Latest deploy log	https://app.netlify.com/projects/pno-project-y/deploys/6a1aebdaa5ce020008033ddb
😎 Deploy Preview	https://deploy-preview-34--pno-project-y.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: af94b2a9-44ef-457b-ba43-8e45161da989

📥 Commits

Reviewing files that changed from the base of the PR and between 7fd1665 and ffe27ea.

📒 Files selected for processing (1)

• src/components/git/TaskDevelopmentSection.tsx

💤 Files with no reviewable changes (1)

• src/components/git/TaskDevelopmentSection.tsx

---

📝 Walkthrough

Walkthrough

TaskDevelopmentEmptyState accepts an optional starting prop to display branch creation in progress. TaskDevelopmentSection introduces startingDevelopment state, a handler for the start flow (mutation, clipboard copy, toasts), and integrates loading UI into both panel and non-panel start-development buttons.

Changes

Start Development Loading State

Layer / File(s)	Summary
Component contract and state foundation src/components/git/TaskDevelopmentEmptyState.tsx, src/components/git/TaskDevelopmentSection.tsx	TaskDevelopmentEmptyState props type accepts optional starting. TaskDevelopmentSection adds startingDevelopment state to manage the start-development lifecycle independently of the shared busy flag.
Empty state UI for starting src/components/git/TaskDevelopmentEmptyState.tsx	When starting is true, the component updates the step description to "Creating branch on GitHub…", the title to "Creating branch…", the description to "Setting up your branch on GitHub…", and sets aria-busy on the <section>.
Start development handler src/components/git/TaskDevelopmentSection.tsx	handleStartDevelopment sets startingDevelopment, calls the start-development mutation with taskId and selected repository, copies checkoutCommand to the clipboard, emits success/error toasts (with special handling for multi-repo selection message), and clears startingDevelopment.
Panel and non-panel UI integration src/components/git/TaskDevelopmentSection.tsx	Both panel and non-panel start-development buttons route clicks to handleStartDevelopment, show loading state, and extend disabled conditions to include startingDevelopment. Repository <Select> is disabled while starting. Panel passes starting={startingDevelopment} to TaskDevelopmentEmptyState.

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly Related PRs

• pnodev/project-y#29: Extends TaskDevelopmentEmptyState with the starting prop and builds on the empty-state integration foundation.

Poem

A rabbit hops through loading states so fine,
With branches sprouting at just the right time,
The clipboard springs with checkout commands clear,
While toasts sing softly that the start is near!
🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'PY-53: Wartezeit nach "Start Development"' references the issue and describes the main change (adding wait time handling after "Start Development"), which aligns with the changes that add loading/starting state feedback during the development flow.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch py-53-wartezeit-nach-start-development

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

src/components/git/TaskDevelopmentSection.tsx (1)

163-182: ⚡ Quick win

finally clearing startingDevelopment is likely correct; flicker premise doesn’t hold

useStartTaskDevelopmentMutation awaits invalidateGitTaskBoardState(), which invalidates ["git","task", taskId]—the same query key used by useTaskGitContextQuery to derive branch. With TanStack Query v5, awaiting invalidateQueries waits for the triggered refetches to complete, so branch should already be updated when startDevelopment resolves. As a result, the described “Wartezeit” window and the “reset effect becomes dead” argument are unlikely; the effect at ~121-125 is probably redundant on the success path.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/git/TaskDevelopmentSection.tsx` around lines 163 - 182, The
effect that clears startingDevelopment when branch changes is redundant because
useStartTaskDevelopmentMutation awaits invalidateGitTaskBoardState (so branch is
updated before startDevelopment resolves); remove the useEffect that watches
branch (the one calling setStartingDevelopment(false) around lines ~121-125) and
keep the existing finally in handleStartDevelopment unchanged; references to
locate the code: handleStartDevelopment, setStartingDevelopment, branch,
useStartTaskDevelopmentMutation, invalidateGitTaskBoardState, and
useTaskGitContextQuery.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/components/git/TaskDevelopmentSection.tsx`:
- Around line 163-182: The effect that clears startingDevelopment when branch
changes is redundant because useStartTaskDevelopmentMutation awaits
invalidateGitTaskBoardState (so branch is updated before startDevelopment
resolves); remove the useEffect that watches branch (the one calling
setStartingDevelopment(false) around lines ~121-125) and keep the existing
finally in handleStartDevelopment unchanged; references to locate the code:
handleStartDevelopment, setStartingDevelopment, branch,
useStartTaskDevelopmentMutation, invalidateGitTaskBoardState, and
useTaskGitContextQuery.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 857169f1-7837-49e5-a470-644f402ab164

📥 Commits

Reviewing files that changed from the base of the PR and between 18909ce and 7fd1665.

📒 Files selected for processing (2)

• src/components/git/TaskDevelopmentEmptyState.tsx
• src/components/git/TaskDevelopmentSection.tsx