[tenant-namespace] Fixed missing podSelector#2
Merged
kfox1111 merged 2 commits intopnnl-miscscripts:masterfrom Dec 16, 2019
Merged
[tenant-namespace] Fixed missing podSelector#2kfox1111 merged 2 commits intopnnl-miscscripts:masterfrom
kfox1111 merged 2 commits intopnnl-miscscripts:masterfrom
Conversation
NetworkPolicy requires a podSelector at the root of the spec
Author
|
I was able to test this on a cluster and it worked with Helm 3. There is an issue with upgrades for the nginx-ingress that I had trouble working around, see here https://github.com/helm/charts/blob/master/stable/nginx-ingress/README.md#helm-error-when-upgrading-specclusterip-invalid-value- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was using Helmfile to install the tenant-namespace chart using Helm 3, validation is turned on and breaks the deployment of the chart due to the missing podSelector. I replicated this issue using
helm template . | kubectl apply --validate=true --dry-run=true -f -where the validation errors out on the missing field. The specific section in the docs is here https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.16/#networkpolicyspec-v1-networking-k8s-io. I believe adding this field will simply match all pods in the current namespace for this policy and it seems like the chart ends up deploying the resource this way.