Skip to content

Publish changes from innersouce#1

Closed
igchor wants to merge 16 commits intopmem:developfrom
igchor:develop
Closed

Publish changes from innersouce#1
igchor wants to merge 16 commits intopmem:developfrom
igchor:develop

Conversation

@igchor
Copy link

@igchor igchor commented Oct 29, 2021

No description provided.

raema and others added 16 commits September 27, 2021 14:42
@raema
move to self hosted github runner
a6d78e6 
move to self hosted github runner
@raema
move to self hosted github runner
c4bcb0f 
move to self hosted github runner
@raema
move to self hosted github runner
03fefaa 
move to self hosted github runner
@raema
move to self hosted github runner
68104eb 
move to self hosted github runner
@raema
sudo proxy settings
4fbc5b1 
configure sudo to keep proxy settings
@raema
sudo proxy settings
c233806 
sudo proxy settings
@raema
sudo proxy settings
bbebc96 
configure sudo to keep proxy settings
@raema
sudo proxy settings
7f5c03b 
configure sudo to keep proxy settings
@victoria-mcgrath
Merge branch 'main' of https://github.com/facebook/CacheLib into main
8241e21
@victoria-mcgrath
Merge remote-tracking branch 'upstream/main' into main
b215be9
@victoria-mcgrath
Merge remote-tracking branch 'upstream/main' into main
c0d723c
@igchor
Introduce FileShmSegment for file-backed shared memory
e768b6d 
It's implementation is mostly based on PosixShmSegment.

Also, extend ShmManager and ShmSegmentOpts to support this new
segment type.
@igchor
Adjust and enable tests for ShmFileSegment
8722a5d
@igchor
Merge pull request pmem#30 from intel-innersource/uid/igchor/shm_mgr_…
e68c4cd 
…fixes

Introduce ShmFileSegment
@guptask
FBSW-184 shm key serialization (pmem#33)
dfcd0f1 
* changes to shm key serialzation

* updated based on comment

* fixed a compiler issue

* fixed compilation issue

* updated a check

* updated the removeAllSegments and removeUnAttachedSegemnts
@victoria-mcgrath
Initial version of config API extension to support multiple memory tiers
f129fe5 
* New class MemoryTierCacheConfig allows to configure a memory tier. Setting tier size and location of a file for file-backed memory are supported in this initial implementation;
* New member, vector of memory tiers, is added to class CacheAllocatorConfig;
* New test suite, chelib/allocator/tests/MemoryTiersTest.cpp, demonstrates the usage of and tests extended config API.
@igchor igchor mentioned this pull request Oct 29, 2021
Merged
guptask
guptask approved these changes Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@guptask guptask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge it without review since these changes have already been reviewed before merge into inner-source main. The commit history looks ok.

@vinser52
Copy link
Collaborator

vinser52 commented Nov 2, 2021

Should we keep commits for self-hosted runners?

@igchor
Copy link
Author

igchor commented Nov 2, 2021

I can manually squash all those self-hosted runners commits to just a single one. @vinser52 would that be ok?

In general, we probably want the self-hoster runners change to be present on develop branch.

@igchor
Copy link
Author

igchor commented Nov 2, 2021

I can also clear up the history by removing the merge commits.

@igchor
Copy link
Author

igchor commented Nov 2, 2021

Here's PR with cleared history: #3

I've also extended description of one commit from @guptask (regarding key serialization) to have some useful info.

@igchor igchor closed this Nov 2, 2021
ss7pro pushed a commit to ss7pro/CacheLib that referenced this pull request Aug 10, 2022
@byrnedj
MM2Q promotion iterators (pmem#1)
acdfa0b 
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
vinser52 pushed a commit that referenced this pull request Sep 13, 2022
@facebook-github-bot
Prevent divide by zero errors in ObjSize controller.
fa5fa64 
Summary:
AdRanker ASAN canary flagged a possible UBSan violation.

## Error
Failed Run: https://fburl.com/servicelab/apytosry
```
    #0 0x562e3adb59bc in facebook::cachelib::objcache2::ObjectCacheSizeController<facebook::cachelib::CacheAllocator<facebook::cachelib::LruCacheTrait> >::work() buck-out/v2/gen/fbcode/47d914adeee3d982/cachelib/experimental/objcache2/__object-cache__/headers/cachelib/experimental/objcache2/ObjectCacheSizeController-inl.h
    #1 0x562de7610f78 in facebook::cachelib::PeriodicWorker::loop() fbcode/cachelib/common/PeriodicWorker.cpp:55
    #2 0x7f7632c524e4 in execute_native_thread_routine /home/engshare/third-party2/libgcc/11.x/src/gcc-11.x/x86_64-facebook-linux/libstdc++-v3/src/c++11/../../../.././libstdc++-v3/src/c++11/thread.cc:82:18
    #3 0x7f7632f6ec0e in start_thread /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/nptl/pthread_create.c:434:8
    #4 0x7f76330011db in clone3 /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81

UndefinedBehaviorSanitizer: integer-divide-by-zero buck-out/v2/gen/fbcode/47d914adeee3d982/cachelib/experimental/objcache2/__object-cache__/headers/cachelib/experimental/objcache2/ObjectCacheSizeController-inl.h:33:40 in
```

Reviewed By: jiayuebao

Differential Revision: D39024188

fbshipit-source-id: 64ad644c360565e638fa3ca74616a315038382ab
vinser52 pushed a commit that referenced this pull request Sep 13, 2022
@byrnedj
MM2Q promotion iterators (#1)
4a6307f 
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
guptask pushed a commit to guptask/CacheLib that referenced this pull request Nov 21, 2022
@facebook-github-bot
improve MapIndexMaxedOut error logging
05897d6 
Summary:
The current exception string for MapIndexMaxedOut is not very useful because ```oldHashTable.viewWriteHandle()->getKey()``` can have null terminators in it and cause the c_str() to be terminated incorrectly. Regardless, the actual write handle key is not very useful to us. Log the aid explicitly.

Example log:
```
Sep 14 07:12:57 tsp_lla/tao/prod-opt-follower/1879 dpdaemon[442]: E0914 07:12:57.836133  1922 Refill.cpp:215] Index has maxed out for key: pmem#1<A4><D1 (https://github.com/facebook/CacheLib/commit/3ec18f5591f75fa5e247cadad19a86126075bdda)>0F<F6>\
```

Reviewed By: vrishal

Differential Revision: D39518530

fbshipit-source-id: 58b9f31f6c0d174d5ec0bc7705788408bc0d11f4
guptask pushed a commit to guptask/CacheLib that referenced this pull request Nov 21, 2022
@byrnedj
MM2Q promotion iterators (pmem#1)
2e9d98f 
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
guptask pushed a commit to guptask/CacheLib that referenced this pull request Mar 7, 2023
@byrnedj
MM2Q promotion iterators (pmem#1)
f0baeb1 
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
guptask pushed a commit to guptask/CacheLib that referenced this pull request Jul 28, 2023
@byrnedj
MM2Q promotion iterators (pmem#1)
489ef20 
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guptask guptask guptask approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@igchor @vinser52 @guptask @raema @victoria-mcgrath