fix: re-instating TYPE_CHECKING to address type-checking issues#5197
Closed
fix: re-instating TYPE_CHECKING to address type-checking issues#5197
Conversation
1. Restore `TYPE_CHECKING` code clauses in `codegen/__init__.py` and `codegen/utils.py`
that were removed in #4978.
1. Update `requires-optional.txt` to specify `black==25.1.0` to be consistent with
version specified in `pyproject.toml`.
1. Change required Python version in `pyproject.toml` to 3.9 because desired version
of `black` does not work with Python 3.8.
closes #5186
gvwilson
added
P1
Contributor
Author
|
closing in favor of split PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE_CHECKINGcode clauses incodegen/__init__.pyandcodegen/utils.pythat were removed in feat: modifying code generation to reduce bundle size #4978.requires-optional.txtto specifyblack==25.1.0to be consistent with version specified inpyproject.toml.pyproject.tomlto 3.9 because desired version ofblackdoes not work with Python 3.8.closes #5186