load plotly.js from unminified dist bundle in plotlywidget#1891
load plotly.js from unminified dist bundle in plotlywidget#1891
Conversation
|
So the |
|
@nicolaskruchten any thoughts on this. We could use the |
|
Perhaps when making this change, please also consider registering the exports in the lab plugin with a lazy load: this will keep it from
Here's how it interacts with the crucial Since it appears to be commonjs, you may have to use the vendor-specific |
|
Here's an example with |
|
@nrbgt While I agree with your point, I believe it should be made as a separate issue. |
|
OK so as I understand it right now, this will bloat the nbextension size because we're not minifying in webpack.config.js. |
With this PR, both
jupyterlab-plotlyandplotlywidgetnow load plotly.js from the unminified dist bundle, so jupyterlab should be able to de-duplicate plotly.js when both extensions are installed.Closes #1873
cc @vidartf