ci: make each package publish step independent#25
Merged
Conversation
Steps default to an implicit success() gate, so prettier-config's failed publish skipped the code-style step entirely. Add !cancelled() so each package publishes regardless of a sibling's outcome.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish steps default to an implicit
success()gate, so prettier-config's failed publish skipped the@pleaseai/code-stylestep entirely (it never ran). Add!cancelled()to each step so a sibling package's failure no longer blocks the rest.Context: in the last
publish_onlyrun,@pleaseai/eslint-config@0.0.4published fine, but@pleaseai/prettier-configfailed (E404 — OIDC trusted publishing can't create a never-before-published package) which skipped@pleaseai/code-style@0.0.3. This unblocks code-style; prettier-config's first publish is handled separately.