chore: remove pinned sha from posthog and revenuecat marketplace entries#199
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the pinned commit SHAs for the PostHog and RevenueCat plugins in .claude-plugin/marketplace.json. The review comments correctly highlight that removing these pinned SHAs introduces supply chain security risks, as these plugins execute in local environments and tracking the latest commits could expose users to upstream compromises. It is recommended to pin these dependencies to specific release tags or versions.
Contributor
There was a problem hiding this comment.
2 issues found across 1 file
Confidence score: 3/5
- The change in
.claude-plugin/marketplace.jsonremoves commit pinning for an external plugin URL, which introduces a concrete supply-chain and reproducibility risk. - This is a meaningful security concern (severity 7/10 with high confidence), so there is some merge risk even though runtime functionality may appear unchanged.
- Because the issue is focused in one config file and is straightforward to remediate by restoring a pinned SHA, the risk is moderate rather than critical.
- Pay close attention to
.claude-plugin/marketplace.json- plugin source resolution is now non-deterministic without a commit pin.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the pinned
shafields from the PostHog (PostHog/ai-plugin) and RevenueCat (RevenueCat/rc-claude-code-plugin) marketplace entries so both plugin sources track the latest commit instead of a fixed SHA.Changes
.claude-plugin/marketplace.json: removedshafield fromposthogentry (wasf2f37954ecef9f1afce4fa81b6a612454a96c410).claude-plugin/marketplace.json: removedshafield fromrevenuecatentry (wasaf7cb77996aee4e7e3c109c5afec81f716139032)Notes
chore:type — no release bump via release-please.Summary by cubic
Removed pinned
shafields forPostHog/ai-pluginandRevenueCat/rc-claude-code-pluginin.claude-plugin/marketplace.json. These marketplace entries now track the latest commit from their repositories.Written for commit 7e8d862. Summary will update on new commits.