Add build definitions for testing plugins#6
Merged
Conversation
Add two build definitions (and a plugin configuration option) that make writing plugin end-to-end tests smoother. They are essentially a convenience wrapper around `please_repo_e2e_test` that simplify the process of building the plugin and making it loadable within the test repo. This requires a version of Please with the `export` command, and would benefit from thought-machine/please#3411 (which allows repos without a top-level `BUILD` file to be buildable), hence the dependency on Please >= 17.19.1.
toastwaffle
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two build definitions (and a plugin configuration option) that make writing plugin end-to-end tests smoother. They are essentially a convenience wrapper around
please_repo_e2e_testthat simplify the process of building the plugin and making it loadable within the test repo.This requires a version of Please with the
exportcommand, and would benefit from thought-machine/please#3411 (which allows repos without a top-levelBUILDfile to be buildable), hence the dependency on Please >= 17.19.1.