Fix ButtonClicker random crash issue [ the crash happens on 64 bit gpg sdk ]#20
Closed
ggfan wants to merge 3 commits intoplaygameservices:masterfrom
Closed
Fix ButtonClicker random crash issue [ the crash happens on 64 bit gpg sdk ]#20ggfan wants to merge 3 commits intoplaygameservices:masterfrom
ggfan wants to merge 3 commits intoplaygameservices:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
can we keep this at 9?
Contributor
Author
|
there are 2 scenarios:
For the above case 1), you could not initDisplay after authentication: I think user need to click/tap a button to start login process It might make sense to force gpg init after UI is initialized, but that would need somewhat re-layout / evaluate overall UI and gpg login code. that would need more experiment. Current fix will make sure we are forcing the thing done in the thread that originated the action [ I think this simplify things ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2)Synchronize UI init with Google Play Games authentication UI with a mutex