Skip to content

Explicitly use Ubuntu 18.04 in CI#457

Merged
elshize merged 1 commit into
masterfrom
explicit-ubuntu-18
May 3, 2021
Merged

Explicitly use Ubuntu 18.04 in CI#457
elshize merged 1 commit into
masterfrom
explicit-ubuntu-18

Conversation

@elshize

@elshize elshize commented May 1, 2021

Copy link
Copy Markdown
Member

ubuntu-latest is now 20.4, and our CI setup fails on that.

@elshize elshize self-assigned this May 1, 2021
@elshize
elshize requested review from JMMackenzie and amallia May 1, 2021 22:23
@codecov

codecov Bot commented May 1, 2021

Copy link
Copy Markdown

Codecov Report

Merging #457 (6bb07b3) into master (196a6e6) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #457   +/-   ##
=======================================
  Coverage   93.21%   93.21%           
=======================================
  Files          92       92           
  Lines        4995     4997    +2     
=======================================
+ Hits         4656     4658    +2     
  Misses        339      339           
Impacted Files Coverage Δ
include/pisa/reorder_docids.hpp 89.65% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 196a6e6...6bb07b3. Read the comment docs.

@JMMackenzie JMMackenzie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but why are we failing on latest and should we be looking to fix it longer term? Thanks for taking care of this!

@elshize

elshize commented May 3, 2021

Copy link
Copy Markdown
Member Author

There are a few reasons it was failing. First, we use 18.04-specific LLVM repos, but that could be easily changed. The second reason is that the default gcc and clang versions are different, so some changes into installing/removing toolchains need to be done.

I figured we shouldn't be using latest anyway, because this will happen in another two years again, when they upgrade to 22.04. We should probably upgrade to 20.04 at some point, but there is no rush.

@elshize
elshize merged commit 9bb4d43 into master May 3, 2021
@elshize
elshize deleted the explicit-ubuntu-18 branch May 3, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants