Explicitly use Ubuntu 18.04 in CI#457
Conversation
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
=======================================
Coverage 93.21% 93.21%
=======================================
Files 92 92
Lines 4995 4997 +2
=======================================
+ Hits 4656 4658 +2
Misses 339 339
Continue to review full report at Codecov.
|
JMMackenzie
left a comment
There was a problem hiding this comment.
LGTM, but why are we failing on latest and should we be looking to fix it longer term? Thanks for taking care of this!
|
There are a few reasons it was failing. First, we use 18.04-specific LLVM repos, but that could be easily changed. The second reason is that the default gcc and clang versions are different, so some changes into installing/removing toolchains need to be done. I figured we shouldn't be using |
ubuntu-latestis now 20.4, and our CI setup fails on that.