Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

tests: stop all fake-gcs-server and oauth during stop services#859

Open
overvenus wants to merge 11 commits intopingcap:masterfrom
overvenus:gcs-port
Open

tests: stop all fake-gcs-server and oauth during stop services#859
overvenus wants to merge 11 commits intopingcap:masterfrom
overvenus:gcs-port

Conversation

@overvenus
Copy link
Member

@overvenus overvenus commented Mar 12, 2021

What problem does this PR solve?

This PR tries to prevent fake gcs server port conflicting by randomlize port number.

Close #795

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No release note

@overvenus
tests: randomize fake gcs server port
5e1e3a2 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@lance6716
Copy link
Contributor

lance6716 commented Mar 12, 2021

/lgtm

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Mar 12, 2021
glorv
glorv reviewed Mar 12, 2021
View reviewed changes
@ti-chi-bot ti-chi-bot added size/S and removed size/XS labels Mar 24, 2021
@overvenus overvenus changed the title tests: randomize fake gcs server port tests: stop all fake-gcs-server and oauth during stop services Apr 21, 2021
@glorv
Copy link
Collaborator

glorv commented Apr 21, 2021

/lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 21, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Apr 21, 2021
@glorv
Copy link
Collaborator

glorv commented Apr 21, 2021

/run-all-tests

@kennytm
Copy link
Collaborator

kennytm commented Apr 21, 2021

/merge

@kennytm
Copy link
Collaborator

kennytm commented Apr 21, 2021

/run-integration-test

@YuJuncen
Copy link
Collaborator

YuJuncen commented Apr 23, 2021

/run-integration-tests

1 similar comment
@kennytm
Copy link
Collaborator

kennytm commented Apr 23, 2021

/run-integration-tests

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 25, 2021

@overvenus: Your PR was out of date, I have automatically updated it for you.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@kennytm
Copy link
Collaborator

kennytm commented Apr 25, 2021

/merge cancel

i think we need to check if the errors are really spurious

@lonng
Copy link
Contributor

lonng commented Jul 7, 2021

Still working in progress?

@glorv
Copy link
Collaborator

glorv commented Jul 7, 2021

/run-all-tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@glorv glorv glorv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherry-pick-approved component/test do-not-merge/work-in-progress status/WIP needs-cherry-pick-release-4.0 size/M status/LGT2 LGTM2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test br_gcs fails

8 participants

@overvenus @lance6716 @glorv @ti-chi-bot @kennytm @YuJuncen @lonng @ti-srebot