Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

backup: parallel backup and checksum to speed up backup#1087

Open
3pointer wants to merge 1 commit intopingcap:masterfrom
3pointer:parallels_backup_checksum
Open

backup: parallel backup and checksum to speed up backup#1087
3pointer wants to merge 1 commit intopingcap:masterfrom
3pointer:parallels_backup_checksum

Conversation

@3pointer
Copy link
Collaborator

@3pointer 3pointer commented May 7, 2021

What problem does this PR solve?

a kind of fix for #1046

What is changed and how it works?

besides pipeline backup and checksum, we can parallel them.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Note

@ti-chi-bot ti-chi-bot requested a review from overvenus May 7, 2021 06:46
@3pointer 3pointer marked this pull request as ready for review June 1, 2021 10:03
@3pointer 3pointer requested review from glorv and kennytm June 1, 2021 10:04
@3pointer 3pointer added this to the v5.1.0 milestone Jun 1, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Jun 9, 2021
@glorv glorv removed this from the v5.1.0 milestone Jun 9, 2021
@ti-chi-bot
Copy link
Member

@3pointer: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants