Skip to content

Themes and hide blocks#77

Open
angeluss88 wants to merge 12 commits into
masterfrom
themes-and-hide-blocks
Open

Themes and hide blocks#77
angeluss88 wants to merge 12 commits into
masterfrom
themes-and-hide-blocks

Conversation

@angeluss88

Copy link
Copy Markdown

No description provided.

@angeluss88

Copy link
Copy Markdown
Author

#40

@pilot

pilot commented Dec 27, 2017

Copy link
Copy Markdown
Owner

@angeluss88 please add description about the theme editing is works now, to the wiki page https://github.com/pilot/eventator/wiki/Manage-themes

Comment thread .gitignore
.idea
!web/uploads/themes/.gitkeep
!web/uploads/themes/test.css
#composer.lock

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Then I wait "10" seconds
Then I should see " My Device "
And I attach the file "test.css" to "fsp-fileUpload"
# Then I wait "15" seconds

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove


public function manageAction(Request $request, $id = null)
{
$css_url = '';

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cssUrl fix CS (code style)

{
$client = new Client();
$file = $client->createRequest('GET', $url)->send()->getBody(true);
return $file;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add nl above the return

return $this->render('EventEventBundle:Event:index.html.twig', []);
}

public function whereItBeAction(){

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put { to the nl

public function findOrCreate()
{
$entity = $this->findOneBy(array(), array('id' => 'ASC'));
if(!$entity){

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if ( add space

$this->_em->persist($entity);
$this->_em->flush();
}
return $entity;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add nl

*/
private $showContactSection = true;

public function __construct()

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

*/
private $file;

private $changedFile;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add annotation


if ( 0 < elementsCount) {
$('#themes').dataTable({
"iDisplayLength": 50,

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use single quotes for parameters

<li><a href="{{ home_page ? '' : path('event_homepage') }}#organizers">Organizers</a></li>
<li><a href="{{ home_page ? '' : path('event_homepage') }}#contact">Contact</a></li>
{% if blocks.showSpeakersSection %}
<li><a href="{{ home_page ? '' : path('event_homepage') }}#speakers">Speakers</a></li>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add trans tag for each string {{ 'Speakers'|trans }}

{% form_theme form 'EventEventBundle::form_theme.html.twig' %}
<div id="contact" class="indent"></div>
<section class="contact_us">
<section class="contact_us" style="{{ blocks.showContactSection ? '' : 'display:none' }}">

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be refactored, do not use show / hide on template level, but show / hide on template level in the layout

@@ -0,0 +1,14 @@
<article class="info bg" style="{{ blocks.showWhereItBeSection ? '' : 'display:none' }}">
<div class="event-place-wrap">
<h2>Where will it be?</h2>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants