Added support for array keys (ids[])#60
Closed
michielgerritsen wants to merge 1 commit intophpclassic:masterfrom
michielgerritsen:bugfix/verify-request
Closed
Added support for array keys (ids[])#60michielgerritsen wants to merge 1 commit intophpclassic:masterfrom michielgerritsen:bugfix/verify-request
michielgerritsen wants to merge 1 commit intophpclassic:masterfrom
michielgerritsen:bugfix/verify-request
Conversation
Author
|
Note: Travis fails due to having more than 50 products in the test shop. I deleted all products and did a local re-run of the test suite, it succeeds now. I can't restart Travis but it should pass now. |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
When adding a bulk order link, you have the ability to selection multiple orders and do a request to your app. The ids are added in the url like this:
ids[]=1&ids[]=2. With this library it is impossible to verify the request because the ids need to be formatted in the following way:ids=["1", "2"]. I changed theverifyShopifyRequestso it support this kinds of request. I also added some test to verify this behaviour.