Haiku fix ZTS build, disabling tls model#8047
Closed
devnexen wants to merge 1 commit intophp:PHP-8.0from
Closed
Conversation
cmb69
approved these changes
Feb 7, 2022
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Thank you! I don't know about Haiku, but you certainly do, so this looks good to me. :)
Contributor
|
@devnexen can you see opcache ext as loaded /w JIT enabled with this, to me incomplete, fix on Haiku? see related issue #8180 (comment) discussion |
Member
Author
|
afaik it is irrelevant in case of haiku as opcache does not work at all in the first place in this platform. |
Contributor
thanks for the reply, still, shouln't Haiku be checked here too Line 739 in abd9529 |
Member
Author
|
sure why not, haiku is still in beta and does not support yet tls model. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.