ext/gd/imagefilter: Improve wording of ArgCount error#20158
Merged
Girgias merged 2 commits intophp:masterfrom Oct 13, 2025
Merged
ext/gd/imagefilter: Improve wording of ArgCount error#20158Girgias merged 2 commits intophp:masterfrom
Girgias merged 2 commits intophp:masterfrom
Conversation
This is done by parsing this as 2 arguments with variadics that are never actually parsed
devnexen
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract GD changes from #20066
Commits
ext/gd/imagefilter: Add test case for manual ZPP
ext/gd/imagefilter: Improve wording of ArgCount error
This is done by parsing this as 2 arguments with variadics that are never actually parsed