Improved fix for bug #54254

[smalyshev]

Improve version of #128

[emosenkis]

One of us added a trailing space here

[emosenkis]

It looks good except that you got the Hebrew name wrong for Adar I (it would translate to Adar 200 instead of 2). I also noticed and fixed two other things:

1. The Hebrew for Adar I and II is not punctuated correctly - the apostrophe should be at the end, not the beginning[1]. I believe this was originally done due to some bidi mistake, but I have tested before and after using simple str_rev and piping through fribidi and it always works better with it moved to the end of the string.
2. The lack of a space in AdarI and AdarII is ugly and seems to be for no reason. All of the tests still pass after I added spaces to make Adar I and Adar II.
   Rather than forking your branch, I just posted my changes as a diff at https://gist.github.com/3274062

[1] See http://en.wikipedia.org/wiki/Hebrew_numerals#Gershayim - the characters mentioned there don't seem to exist in ISO-8859-8 so we're stuck with single and double quotes

[smalyshev]

These things are hard to do on my comp since it's in ISO-8859-8 and none of my text editors understands it and none supports bi-di without UTF-8, so I was doing it blind more or less. Thanks for fixing it. I wonder if we should move the strings to UTF-8 - everybody uses that nowdays anyway...

[emosenkis]

Let's commit this set of fixes and when I get back from vacation I can try to change them all to UTF-8 - I type in Hebrew well enough that it shouldn't be too much trouble. It might be nice to add a note in the documentation that mentions that it's currently ISO-8859-8. There are a bunch of improvements that could be made to the Hebrew output of jdtojewish, but I don't have the time right now to do all of them and I want to make sure that the main part of this bug gets fixed in the next possible release.

[php-pulls]

Comment on behalf of stas at php.net:

merged