tests(ext-curl): fix HTTP/2 Server Push tests

[dunglas]

• Use Caddy to expose local URLs supporting Server Push
• Unskip tests for Server Push
• Add a new test for Server Push

[iluuu1994]

Great! I'm not well versed with HTTP and Curl, I had to look up how these options work but from what I can tell the test looks good. Thank you 🙂

[iluuu1994]

Sorry for the late response. I see the check was changed to fsockopen("localhost") (instead of trying for /serverpush). If there's a local server running the test will attempt to run as well. If there's a problem with testing for /serverpush an env variable might be better after all. Sorry for the back and forth.

[dunglas]

The main problem is that file_get_contents doesn't have support for TLS (and so HTTS) by default, at least on my machine.

That's why I used fsockopen instead.

I could try to use curl instead of file_get_contents, but the check will take more lines of code.

[iluuu1994]

I guess that could be moved to a shared skipif file if too long. If it doesn't work well I won't object to a env var.

[dunglas]

@iluuu1994 is there anything more to do on this patch?

[staabm]

Fwiw, most browsers and servers drop support for http2 server push.

Not sure whether keeping it in php is the right direction

See e.g.

• https://twitter.com/nginxorg/status/1668741255549911040

• https://developer.chrome.com/blog/removing-push/

I am no expert, just mention what I found by accident

[dunglas]

Indeed Chrome recommends 103 Early Hints (status in PHP: #7025) now, but Server Push is still supported by many tools (server-side and client-side) and will not be removed from the spec.

Anyway, enabling these tests is not related to the status of Server Push. As long as the code is part of PHP (and of curl) and officially supported, it should be tested.

If we (or curl) remove this feature at some point, then we'll remove the corresponding tests.

[iluuu1994]

Hi @dunglas! Sorry for the late response, again... I get some segfaults running this locally, do you also get these? The output is from building with --enable-address-sanitizer.

[dunglas]

Segfaults have been fixed in libcurl 8.1.0. I skipped these tests if libcurl version is older.

[iluuu1994]

At last 😄 Thanks @dunglas!