Conversation
makasim
reviewed
Oct 22, 2018
pkg/wamp/WampConsumer.php
Outdated
| */ | ||
| public function acknowledge(Message $message): void | ||
| { | ||
| // do nothing. redis transport always works in auto ack mode |
makasim
reviewed
Oct 22, 2018
pkg/wamp/WampConsumer.php
Outdated
| { | ||
| InvalidMessageException::assertMessageInstanceOf($message, WampMessage::class); | ||
|
|
||
| // do nothing on reject. redis transport always works in auto ack mode |
makasim
reviewed
Oct 22, 2018
makasim
reviewed
Oct 22, 2018
pkg/wamp/WampMessage.php
Outdated
| $this->redelivered = false; | ||
| } | ||
|
|
||
| public function jsonSerialize(): array |
Member
There was a problem hiding this comment.
could you use a concept from rdkafka transport (with a serializer interface)?
makasim
reviewed
Oct 22, 2018
pkg/wamp/LICENSE
Outdated
| @@ -0,0 +1,20 @@ | |||
| The MIT License (MIT) | |||
| Copyright (c) 2017 Kotliar Maksym | |||
makasim
reviewed
Oct 22, 2018
pkg/wamp/README.md
Outdated
| @@ -0,0 +1,27 @@ | |||
| # Web Application Messaging Protocol Transport | |||
Member
There was a problem hiding this comment.
`# Web Application Messaging Protocol (WAMP) Transport
makasim
reviewed
Oct 22, 2018
pkg/wamp/WampConsumer.php
Outdated
|
|
||
| $this->client->getLoop()->run(); | ||
|
|
||
| return $this->message ?: null; |
Member
There was a problem hiding this comment.
We will have 100 clients in the context if we receive 100 message, right? Could we somehow reset them once a message has been received ?
makasim
reviewed
Oct 22, 2018
21 tasks
Member
|
Add docs, update readme. |
Member
Member
|
resolve conflicts |
makasim
reviewed
Oct 23, 2018
makasim
reviewed
Oct 23, 2018
Member
makasim
reviewed
Oct 23, 2018
pkg/wamp/WampConnectionFactory.php
Outdated
| { | ||
| $dsn = new Dsn($dsn); | ||
|
|
||
| if ('wamp' !== $dsn->getSchemeProtocol()) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web Application Messaging Protocol (WAMP) Transport
A transport for Web Application Messaging Protocol.
WAMP is an open standard WebSocket subprotocol.
It uses internally Thruway PHP library voryx/thruway
Installation
Start the WAMP router
Thruway is now running on 127.0.0.1 port 9090
Create context
Consume message:
Start message consumer before send message to the topic
Subscription consumer
Send message to topic
back to index