Fixed #7: Docker-based development of Rig.#8
Merged
Conversation
Contributor
Author
|
This fixes #7. |
Member
|
@grayside Do you think we should remove the cgo compilation for resolving the dnsdock container by domain name and instead inspect the container for IP address and perform the lookup that way? |
Contributor
Author
|
@febbraro If that removes our only dependency on cgo I think it should help avoid some real headaches. Without it you could automate the builds which seems nice. |
Member
|
@grayside ok, lets get this merged and I'll open another issue/PR around removing the cgo dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in the docker-compose file, I was unable to get the dynamic linking of -cgo compilation to work in the container. However, it does produce a working binary that can do things, I'm just not sure what it fails at right now.
rig dashboardandrig startseemed to work fine.