Skip to content

Do not compare client/server Docker versions on Linux.#75

Merged
febbraro merged 1 commit intodevelopfrom
doctor/linux-compat-docker-version
Oct 10, 2017
Merged

Do not compare client/server Docker versions on Linux.#75
febbraro merged 1 commit intodevelopfrom
doctor/linux-compat-docker-version

Conversation

@grayside
Copy link
Contributor

@grayside grayside commented Oct 7, 2017

The client/server comparison is not needed on Linux, where we assume local docker host use. Further, the server version is dependent on docker-machine.

@grayside grayside requested a review from febbraro October 7, 2017 00:39
@febbraro febbraro merged commit 9957253 into develop Oct 10, 2017
@febbraro febbraro deleted the doctor/linux-compat-docker-version branch October 10, 2017 18:16
febbraro added a commit that referenced this pull request Oct 10, 2017
* added linux bind volume support

* go fmt fixes

* rebuid the bind volume every time (in case the absolute path has changed)

* Do not compare client/server Docker versions on Linux. (#75)

* added linux bind volume support

* go fmt fixes

* rebuid the bind volume every time (in case the absolute path has changed)

* Updated for better doctor/linux compat

* refactored to handle linux sync volume and default windows/mac to unison sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants