Add configurable timeouts for sync:start.#57
Conversation
| Value: 10, | ||
| Usage: "Maximum amount of time in seconds to wait for the unison container to start", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Agreed about an environment variable.
Do we really have situations where both timeouts will be independently adjusted? Should we just have a --timeout flag and set the container start timeout to a percentage of the total timeout?
There was a problem hiding this comment.
Sans a desire to detect an issue as soon as possible the answer is likely no. I've actually not seen anyone suffer from waiting for the container to start timing out, it was added as a function of "since I'm in here . . . "
|
Can we just set it via the outrigger.yml file? |
|
The need is for specific convoluted operations, projects with large codebases, and laptops with performance issues. Config file covers one of these |
|
@grayside What do you mean "Config file covers one of these" |
|
Hit send too fast I suppose:
Of these, a config file driven approach to setting the timeout is really only routinely applicable to point 2. Point 1 is exception and would be better to set in the moment (perhaps even with an ignore-timeout sort of option), and point 3 is idiosyncratic to the individual, pointing to a need for a shell setting or an .outrigger.local.yml if it's to be set in a file. |
Fixes #53
This sourced out of some troubleshooting with Mauricio where it took his machine quite a while to do the initial sync.
It occurs to me that maybe we should also allow for specification of this by environment variable since if someone needs this they probably need it the whole time. Especially since the sync:start will likely be getting trigged via an up alias in .outrigger.yml