Handle versions more broadly to account for the new Docker versioning scheme#16
Merged
Handle versions more broadly to account for the new Docker versioning scheme#16
Conversation
grayside
reviewed
Mar 8, 2017
| output, _ := exec.Command("docker", "--version").Output() | ||
| re := regexp.MustCompile("Docker version ([\\d|\\.]+)") | ||
| versionNumber := re.FindAllStringSubmatch(string(output), -1)[0][1] | ||
| re := regexp.MustCompile("Docker version (.*),") |
Contributor
There was a problem hiding this comment.
Was the previous regex used for validation? Seems we've removed all constraints from versioning. Maybe it should still exclude spaces?
Member
Author
There was a problem hiding this comment.
The format is "Docker version [theversionnumber], build [buildhash]" so feel comfortable (for now) grabbing everything before the space.
grayside
reviewed
Mar 8, 2017
Contributor
grayside
left a comment
grayside
left a comment
There was a problem hiding this comment.
Commented on a regex but mostly because I never looked at it closely before.
tekante
approved these changes
Mar 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, versions were only numbers (1.13.1) and not padded. Now, numbers are padded and with letters (17.03.0-ce).
Machine creation fails b/c it does not create the proper boot2docker URL so the ISO is not found.