Merged
Conversation
grayside
reviewed
Oct 27, 2017
| - "../scripts/test-go-fmt.sh" | ||
| - "go run main.go" | ||
| - "scripts/test-go-fmt.sh" | ||
| - "go run cmd/main.go" |
Contributor
There was a problem hiding this comment.
Should we just drop main.go in the root? Not sure what the cmd subdirectory adds in that case. Other than that minor thought, this looks grand.
Member
Author
There was a problem hiding this comment.
I looked for inspiration form other go based CLI projects and this was a convention they used pretty regularly. Also, GoReleaser defaults to the repo root for main.go, but they show an example of overriding it and that example uses cmd/main/go
I think I just didnt; want any go files in the root where I expect to see config and other things.
grayside
approved these changes
Oct 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo is now reorg'd to not have all the code in a subfolder.