Skip to content

fix(ci): adopt dependabot-rebase standard (correct SHA + dispatch trigger)#109

Closed
don-petry wants to merge 2 commits into
mainfrom
fix/dependabot-rebase-adopt-standard
Closed

fix(ci): adopt dependabot-rebase standard (correct SHA + dispatch trigger)#109
don-petry wants to merge 2 commits into
mainfrom
fix/dependabot-rebase-adopt-standard

Conversation

@don-petry

Copy link
Copy Markdown
Contributor

Adopts standards/workflows/dependabot-rebase.yml verbatim. Pins reusable to correct SHA 3c6335c0a214bba940bbcbc4346e9d4ab0cb63e1, adds workflow_dispatch trigger, fixes permissions/secrets block. Supersedes prior SHA-pinning and dispatch PRs.

Copilot AI review requested due to automatic review settings April 17, 2026 06:55
@coderabbitai

coderabbitai Bot commented Apr 17, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 53 minutes and 27 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0dba7db2-29db-43e5-baca-3ad3e8af790b

📥 Commits

Reviewing files that changed from the base of the PR and between 681b417 and 055f72b.

📒 Files selected for processing (1)
  • .github/workflows/dependabot-rebase.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dependabot-rebase-adopt-standard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 53 minutes and 27 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s Dependabot rebase workflow stub to align with the organization standard, ensuring the reusable workflow is pinned correctly and can be manually triggered when needed.

Changes:

  • Add workflow_dispatch to allow manually triggering the Dependabot rebase workflow.
  • Pin the reusable workflow to the specified commit SHA and adjust job permissions/secrets to match the standard.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +45 to +47
secrets:
APP_ID: ${{ secrets.APP_ID }}
APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }}
@don-petry

don-petry commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author
Superseded by automated re-review at e0886512c9fdfd51836fcf070403a0d6b1fbc7bd — click to expand prior review.

Automated review — APPROVED

Risk: MEDIUM
Reviewed commit: 285ca75326204adb99542ffe8373f4f98b3f465c
Cascade: triage → deep (see triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6 for models)

Summary

Single-file GitHub Actions workflow change adopting org standard: SHA-pinned reusable ref (security improvement over mutable @v1 tag), explicit secrets replacing blanket secrets: inherit (more restrictive, positive), and read→write permission escalation justified by rebase operation requirements. All CI checks pass (CodeQL, SonarCloud, AgentShield all green); net security posture is improved.

Findings

Info

  • .github/workflows/dependabot-rebase.yml:40 — Permission escalated from contents: read to contents: write — necessary for branch-update/rebase but also grants ability to touch .github/workflows/. Comment in code explicitly acknowledges this. Reusable workflow is SHA-pinned, limiting blast radius.
  • .github/workflows/dependabot-rebase.yml:41pull-requests: write added — required to re-approve PRs post-rebase. Scoped to job level, acceptable.
  • .github/workflows/dependabot-rebase.yml:43 — Positive change: secrets: inherit (passes all secrets) replaced with explicit APP_ID / APP_PRIVATE_KEY secrets. Reduces secret surface area.
  • .github/workflows/dependabot-rebase.yml:42 — Positive change: reusable workflow ref changed from mutable tag @v1 to SHA-pinned @3c6335c0a214bba940bbcbc4346e9d4ab0cb63e1, preventing tag-hijack supply chain risk.
  • (no file) — All CI checks pass: CodeQL SUCCESS, SonarCloud quality gate passed (0 new issues, 0 security hotspots), AgentShield SUCCESS.

CI status

All CI checks pass: CodeQL SUCCESS, SonarCloud quality gate passed (0 new issues, 0 security hotspots), AgentShield SUCCESS.


Reviewed by the don-petry PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6). Reply with @don-petry if you need a human.

@don-petry don-petry enabled auto-merge (squash) April 17, 2026 08:42

@petry-projects-pr-review-agent petry-projects-pr-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by the don-petry PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6). Reply with @don-petry if you need a human.

@petry-projects-pr-review-agent petry-projects-pr-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: a6a83ffb7b99f604dd608a6bb643f9fa1ac9fe0e
Review mode: triage-approved (single reviewer)

Summary

PR #104 adds a single idempotent bash script (.github/scripts/apply-repo-settings.sh, 48 lines) that enforces org-standard repository settings via gh api -X PATCH. This directly resolves compliance issue #90 (delete_branch_on_merge must be true). No production code is changed — the script is a manual admin tool requiring an explicit GH_TOKEN with admin scope at runtime. No substantive code changes since the prior cascade review (only merge commits and a CI retrigger).

Linked issue analysis

  • Closes #90 — Compliance audit flagged delete_branch_on_merge as null (expected true). The script sets delete_branch_on_merge=true along with all other org-standard defaults. The setting was also applied directly via the API per the PR description. Issue is substantively addressed.

Findings

No blocking issues. Minor observations (informational only, not blocking):

  • [info] -F (typed field) is used for string enum values like squash_merge_commit_title=PR_TITLE. The gh CLI handles this correctly, though -f (raw string) would be slightly more self-documenting for non-boolean/non-numeric values.
  • [info] REPO is hardcoded to petry-projects/markets. This is intentional and appropriate for a compliance-enforcement script scoped to this repository.

CI status

All checks passed:

  • ✅ CodeQL (actions) — SUCCESS
  • ✅ SonarCloud — SUCCESS (0 new issues, 0 security hotspots)
  • ✅ AgentShield — SUCCESS
  • ✅ CodeRabbit — SUCCESS
  • ✅ Dependency audit — ecosystem detection SUCCESS, language-specific audits SKIPPED (no applicable ecosystems)
  • ✅ CI — ecosystem detection SUCCESS, Backend/Frontend SKIPPED (no changes to those layers)

Reviewed automatically by the don-petry PR-review agent (single-reviewer, triage-approved). Reply with @don-petry if you need a human.

@petry-projects-pr-review-agent petry-projects-pr-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: e0886512c9fdfd51836fcf070403a0d6b1fbc7bd
Review mode: triage-approved (single reviewer)

Summary

Single-file GitHub Actions workflow change adopting the org-standard dependabot-rebase caller stub. Pins the reusable workflow to SHA 3c6335c0 (replacing mutable @v1 tag), replaces blanket secrets: inherit with explicit APP_ID/APP_PRIVATE_KEY, adds workflow_dispatch trigger, and escalates job permissions from read to write (justified by rebase and re-approve operations). Net security posture is improved.

Linked issue analysis

No linked issues. PR description states it supersedes prior SHA-pinning and dispatch PRs — this is a standards-adoption change with self-contained motivation.

Findings

No blocking issues.

Positive changes:

  • Reusable workflow ref changed from mutable tag @v1 to SHA-pinned @3c6335c0a214bba940bbcbc4346e9d4ab0cb63e1 — prevents tag-hijack supply-chain risk.
  • secrets: inherit (passes all repo secrets) replaced with explicit APP_ID / APP_PRIVATE_KEY — reduces secret surface area.

Informational:

  • Permission escalation from contents: read / pull-requests: read to contents: write / pull-requests: write — necessary for the reusable workflow to update branches and re-approve PRs post-rebase. Inline comments document the rationale. Blast radius is limited by the SHA-pinned reusable ref.
  • workflow_dispatch trigger added — allows manual flush of the Dependabot PR queue. Low risk.

CI status

All checks passed:

  • ✅ CodeQL (actions) — SUCCESS
  • ✅ SonarCloud — SUCCESS (0 new issues, 0 security hotspots)
  • ✅ AgentShield — SUCCESS
  • ✅ CodeRabbit — SUCCESS
  • ✅ Dependency audit — ecosystem detection SUCCESS
  • ✅ CI — ecosystem detection SUCCESS

Reviewed automatically by the don-petry PR-review agent (single-reviewer mode: opus 4.6). Reply with @don-petry if you need a human.

@petry-projects-pr-review-agent petry-projects-pr-review-agent Bot dismissed their stale review April 30, 2026 03:26

Superseded by automated re-review at e088651.

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved manually.

Please resolve the conflicts and push:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

@claude Please address all open review comments on this PR from CodeRabbit and Copilot.

@claude

claude Bot commented May 6, 2026

Copy link
Copy Markdown

Claude encountered an error —— View job


I'll analyze this and get back to you.

@don-petry don-petry force-pushed the fix/dependabot-rebase-adopt-standard branch from 055f72b to eac6c20 Compare May 13, 2026 17:09
@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Contributor Author

Closing — after rebasing onto main, this branch has no remaining commits. The fix was already incorporated into main via a subsequent PR.

@don-petry don-petry closed this May 13, 2026
auto-merge was automatically disabled May 13, 2026 17:25

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants