fix(feature-ideation): deploy discussion:created trigger to live caller + correct reusable pin

[don-petry]

Why

Creating a new Idea Discussion did not trigger the Feature Ideation workflow (reported against .github-private Discussion #656). There was no open PR or issue tracking this.

Root cause is two un-propagated gaps from PR #448 (feat: auto-enhance new Ideas Discussions on creation):

1. The trigger was only added to the canonical template, never to the live caller. PR feat(feature-ideation): auto-enhance new Ideas Discussions on creation #448 added on: discussion: [created] + target_discussion single-idea mode to standards/workflows/feature-ideation.yml, but the deployed .github/workflows/feature-ideation.yml was never re-synced — it still triggered on schedule + workflow_dispatch only. So nothing listened for new-Discussion events.

2. The pinned reusable SHA predated the feature. The live caller pinned 7bf5a75b (2026-06-07), whose reusable has zero references to target_discussion. Even if the trigger had fired, single-idea mode could not run. The template's own pin (ee22b427) is likewise missing the input.

What changed

.github/workflows/feature-ideation.yml (live caller)

• Add on: discussion: types: [created].
• Add the job-level if: guard — only run on the discussion trigger for new Ideas-category Discussions authored by a non-Bot (prevents re-enhancing the bot's own scheduled output; enhancement posts a comment, which does not re-fire discussion: created). Schedule/dispatch runs are unaffected.
• Wire target_discussion: ${{ github.event.discussion.number }}.
• Bump the pinned reusable from 7bf5a75b → 897e4de, which actually contains target_discussion support.

standards/workflows/feature-ideation.yml (canonical template)

• Correct the stale pin ee22b427 → 897e4de so the source of truth matches.

project_context and sources_file are preserved unchanged.

⚠️ Maintainer follow-ups (could not be done from this session)

1. Bump the v1 tag. It currently points to d3d768da (2026-05-12), which does not contain the target_discussion reusable commit (f471b21 / feat(feature-ideation): auto-enhance new Ideas Discussions on creation #448) — git merge-base confirms neither v1 nor v2 contains it. I attempted to move v1 → 897e4de but the push proxy rejects tag force-pushes (403); only the feature branch is writable here, and no GitHub API tool to move a ref is available in this session. Please run:

   git tag -f v1 897e4dede3518cdd7273b9dc63e607d0d05cbdda && git push origin v1 --force
   

   This caller pins the SHA directly, so the fix works at runtime without the tag bump — but bumping v1 fixes every other @... # v1 consumer and makes the # v1 comments truthful.

2. .github-private (where Discussion #656 was created) needs the same caller update. It is outside this repo's scope, so it isn't touched here. Re-sync its .github/workflows/feature-ideation.yml from the corrected standards/workflows/feature-ideation.yml and confirm it has an "Ideas" Discussion category.

https://claude.ai/code/session_01PhN5QmeoX3CkfL6iPkzdzb

---

Generated by Claude Code

Summary by CodeRabbit

• Chores
  • Updated automation workflows to trigger on discussion creation events for the ideas category, excluding bot-generated discussions.
  • Updated workflow automation references to latest versions for improved functionality and stability.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2119b933-0728-4967-abb6-e3da70875fd8

📥 Commits

Reviewing files that changed from the base of the PR and between bb7964a and 39ed7d6.

📒 Files selected for processing (2)

• .github/workflows/feature-ideation.yml
• standards/workflows/feature-ideation.yml

---

📝 Walkthrough

Walkthrough

The feature-ideation caller workflow gains a discussion:created trigger, a job-level if guard restricting execution to non-bot users posting in the ideas category, and a new target_discussion input wired from github.event.discussion.number. The reusable workflow pinned SHA is bumped in both the active and standards copies of the caller workflow.

Changes

Feature Ideation: discussion:created trigger and single-idea mode

Layer / File(s)	Summary
Discussion trigger, job guard, and target_discussion input .github/workflows/feature-ideation.yml	Adds on.discussion.types: [created] trigger; adds if guard on the ideate job to allow only ideas-category discussions created by non-bot users; updates the reusable workflow uses: SHA pin; adds with.target_discussion: ${{ github.event.discussion.number }} input.
Standards caller workflow SHA pin bump standards/workflows/feature-ideation.yml	Updates the ideate job's uses: pinned SHA to the same new reusable workflow revision.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

• Deploy discussion:created trigger to .github-private feature-ideation workflow (+ bump v1 tag) #458: This PR directly implements the discussion:created trigger deployment and single-idea mode (job guards and reusable workflow pin update) described in that issue's Task 1.

Possibly related PRs

• petry-projects/.github#448: Introduced the target_discussion input and single-Discussion enhancement mode in the reusable workflow that this PR's caller wiring depends on.
• petry-projects/.github#149: Also updates the pinned feature-ideation-reusable.yml SHA in .github/workflows/feature-ideation.yml, directly parallel to this PR's SHA bump.
• petry-projects/.github#88: Modified standards/workflows/feature-ideation.yml by changing the uses: pinned reference, the same file and field updated here.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main changes: adding the discussion:created trigger to the live workflow caller and updating the reusable workflow pinned revision.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/feature-ideation-workflow-trigger-d8anji

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request updates the commit hash of the reusable GitHub Actions workflow feature-ideation-reusable.yml to 897e4dede3518cdd7273b9dc63e607d0d05cbdda. There are no review comments, and I have no feedback to provide.

[don-petry]

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

[don-petry]

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

**PR Changes (verified):**
The diff shows legitimate workflow updates:
- Added `discussion: [created]` trigger to feature-ideation workflow
- Added conditional guard to run only for new ideas in Ideas category and skip bot creations
- Updated reusable workflow SHA from `7bf5a75b` → `897e4de` (v1 pin) in both caller and template
**Bot Issues Addressed:** 0  
**Files Changed:** 
- `.github/workflows/feature-ideation.yml`
- `standards/workflows/feature-ideation.yml`
**Conclusion:** No actionable issues. The quality gate passed—the PR is ready.

[don-petry]

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #457
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-06-14T08:47:31Z

[don-petry]

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-06-14T08:47:31Z

[don-petry]

Dev-Lead — fix-reviews (no-changes)

Agent reasoning

Addressed 0 threads:
(no open threads)
Test verification: skipped — no code changes made
Files changed: none
PR is in a clean state: all CI checks pass (one job still in_progress but not failed),
coderabbitai has approved, and no open review threads remain.
```

[don-petry]

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

[don-petry]

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

Issues addressed: 0
- No actionable code issues found
Files changed: none (Quality Gate passed; no issues to fix)
Skipped (informational): N/A
```
The SonarCloud Quality Gate passed with 0 new issues and 0 security hotspots. There are no code quality or security vulnerabilities to address. The PR is ready to merge from a bot comment perspective.

[don-petry]

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

[sonarqubecloud]

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

[don-petry]

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #457
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-06-15T12:08:53Z

[don-petry]

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-06-15T12:08:53Z

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[don-petry]

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

[donpetry-bot]

Automated review — APPROVED ✓

Risk: MEDIUM
Reviewed commit: 6da4b8585768cb26422854fcb23bc4477c56f8ae
Review mode: triage-approved (single reviewer)

Summary

Re-syncs the live feature-ideation caller with the canonical template: adds the discussion:created trigger, an Ideas-category/non-Bot job guard, the target_discussion input, and bumps the pinned reusable SHA 7bf5a75 -> 897e4de in both caller and template. Verified against the prior PR #448 gaps.

Linked issue analysis

No formally linked issue (closingIssuesReferences empty). The PR body documents the motivation (reported via Discussion #656; un-propagated gaps from PR #448) and CodeRabbit notes a related-but-unlinked issue #458. Motivation is well-substantiated; absence of a closing-issue link is not a blocker.

Findings

• Verified SHA 897e4dede3518cdd7273b9dc63e607d0d05cbdda exists in petry-projects/.github and its reusable workflow defines (target_discussion:, line 67) and consumes (TARGET_DISCUSSION, line 226) the input; the old pin 7bf5a75b has zero references — confirming the reported bug and the fix.
• target_discussion: ${{ github.event.discussion.number }} passes an integer, not attacker-controllable text — no script-injection vector.
• Job guard github.event_name != 'discussion' || (category.slug == 'ideas' && user.type != 'Bot') is sound: schedule/dispatch runs are unaffected; discussion runs are correctly scoped and bot self-triggering is prevented.
• Reusable is first-party (same org repo), pinned to a full 40-char SHA. No new permission escalation; top-level permissions: {} preserved.
• Maintainer follow-ups noted in the PR body (bump v1 tag; re-sync .github-private caller) are out of this PR's scope and do not block — the direct SHA pin makes the fix work at runtime regardless of the tag.

CI status

All checks green or appropriately skipped: CI Lint/ShellCheck, CodeQL, AgentShield, SonarCloud (Quality Gate passed after an earlier transient failure), gitleaks, Feature Ideation Tests, dependency audit — all SUCCESS/SKIPPED. CodeRabbit APPROVED at head SHA; gemini-code-assist reviewed with no feedback. mergeStateStatus is BLOCKED solely due to the required org-leads human review (REVIEW_REQUIRED).

---

Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.