feat: implement issue #329 — [Fleet Monitor] petry-projects/.github — ci.yml

[don-petry]

Closes #329

Implemented by dev-lead agent. Please review.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[gemini-code-assist]

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

[coderabbitai]

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 46 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 951ae02a-5556-4baf-b6c2-20b12db41165

📥 Commits

Reviewing files that changed from the base of the PR and between 9d0e5c9 and 0904346.

📒 Files selected for processing (1)

• .github/workflows/ci.yml

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dev-lead/issue-329-20260609-0440

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[don-petry]

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

[Copilot]

Pull request overview

Updates the repository’s CI workflow to surface all lint failures in a single run (rather than stopping at the first failing lint step), aiming to reduce repeated “fix → push → fail” cycles that contribute to a degraded failure-rate metric.

Changes:

• Adds if: always() to the YAML lint step so it runs even if Markdown lint fails.
• Adds if: always() to the GitHub Actions lint step so it runs even if earlier lint steps fail.
• Documents the rationale to clarify that the overall Lint job status/branch-protection behavior remains unchanged.

[don-petry]

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

Issues addressed: 0
Files changed: (none)
Skipped (informational): 0
no-changes
```

[don-petry]

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

[donpetry-bot]

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: b21e02e37c9d504bd3857f33afcb2c95952c57f5
Review mode: triage-approved (single reviewer)

Summary

Adds if: always() to the Lint YAML and Lint GitHub Actions sub-steps of the Lint job in .github/workflows/ci.yml so all lint sub-steps run even if an earlier one fails. The job-level pass/fail outcome (and therefore the Lint status check used by branch protection) is unchanged.

Linked issue analysis

Closes #329 — "DEGRADED: ci.yml 26.6% failure rate". This PR doesn't directly reduce the failure rate of the underlying lint problems; instead it improves the developer-feedback loop by surfacing every lint issue per run, which should cut the fix→push→discover-more cycle and indirectly reduce churn. The linkage is reasonable for a low-risk DX improvement, though it doesn't address the root causes of any specific failing lint rules.

Findings

• if: always() is correctly applied at the sub-step level; first step (Lint Markdown) intentionally has no condition since nothing precedes it, and downstream sub-steps will now run even if it fails — matches the stated intent.
• Inline comment clearly documents the rationale and notes the unchanged job-level semantics for branch protection. Good defensive documentation.
• No security, secrets, permissions, or action-pinning changes. permissions: {} at the workflow level and contents: read on the job are unchanged.
• No changes to action SHAs, scripts, or external network calls.
• No standards violations (AGENTS.md / ci-standards.md): this is consistent with the lint-everything philosophy.

CI status

All required checks SUCCESS: Lint, ShellCheck, Agent Security Scan, Secret scan (gitleaks), CodeQL, AgentShield, SonarCloud, Dev-Lead, PR Auto-Review ready check. Dependency-audit ecosystem subjobs SKIPPED (no matching ecosystems). Merge state is BEHIND (not blocking — branch is behind main but mergeable).

---

Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.

[don-petry]

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #423
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-06-10T14:04:43Z

[don-petry]

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-06-10T14:04:43Z

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud