Skip to content

fix(compliance): disable false positive reusable-workflow-path-duplicate-github check#165

Merged
don-petry merged 1 commit into
mainfrom
fix/compliance-audit-false-positive
Apr 28, 2026
Merged

fix(compliance): disable false positive reusable-workflow-path-duplicate-github check#165
don-petry merged 1 commit into
mainfrom
fix/compliance-audit-false-positive

Conversation

@don-petry

Copy link
Copy Markdown
Contributor

Summary

Disables a false-positive compliance audit check that incorrectly flags the correct GitHub reusable workflow reference pattern.

Issue: The compliance audit was flagging petry-projects/.github/.github/workflows/... as incorrect
Root cause: The check didn't account for GitHub's reusable workflow syntax where the first segment is the repo name and the second is the path within that repo
Solution: Disable the check and document why the double .github/ pattern is correct per org standards

Affected Repositories

This fix prevents false-positive compliance issues across 6 repos:

Changes

  • Disabled check_reusable_workflow_paths() in scripts/compliance-audit.sh
  • Added documentation explaining the correct pattern per GitHub's reusable workflow syntax
  • Reduces compliance audit noise going forward

Reference

GitHub Reusable Workflows: https://docs.github.com/en/actions/using-workflows/reusing-workflows

Correct pattern: uses: petry-projects/.github/.github/workflows/workflow-name.yml@v1

…ate-github check

The check incorrectly flagged petry-projects/.github/.github/workflows/ as invalid,
but this is the CORRECT pattern per GitHub's reusable workflow syntax:
- First .github = repository name
- Second .github/workflows = directory path within that repository

This check was producing false positives across all repos:
- petry-projects/TalkTerm (issues #131, #130, #129)
- petry-projects/broodly (issues #159, #158)
- petry-projects/google-app-scripts (issues #226, #225)
- petry-projects/ContentTwin (issues #111, #110)
- petry-projects/markets (issues #137, #136)
- petry-projects/bmad-bgreat-suite (issues #123, #122)

Disable the check to reduce compliance audit noise and prevent auto-issue creation
for valid patterns.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 28, 2026 13:50
@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@don-petry has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 55 minutes and 41 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 40ab93d5-cca1-4f9a-bb87-39ffb5b93f4a

📥 Commits

Reviewing files that changed from the base of the PR and between 5b345af and c17dcfb.

📒 Files selected for processing (1)
  • scripts/compliance-audit.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/compliance-audit-false-positive

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables a compliance-audit check that incorrectly flagged the org-standard GitHub reusable workflow reference pattern petry-projects/.github/.github/workflows/... as invalid.

Changes:

  • Removes the prior “duplicate .github/” detection logic from check_reusable_workflow_paths().
  • Adds inline documentation explaining why the double .github/ pattern is correct for the .github repo per GitHub reusable workflow syntax.
  • Replaces the check implementation with a no-op return 0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# Reference: https://docs.github.com/en/actions/using-workflows/reusing-workflows
# Example: uses: petry-projects/.github/.github/workflows/claude-code-reusable.yml@v1
check_reusable_workflow_paths() {
local repo="$1"

Copilot AI Apr 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check_reusable_workflow_paths now declares local repo="$1" but never uses it (the function immediately returns). ShellCheck will flag this as an unused variable (SC2034), which can fail CI. Remove the local assignment, or reference the value (e.g., via a no-op like : "$1") while keeping the signature.

Suggested change
local repo="$1"
: "$1"

Copilot uses AI. Check for mistakes.
@don-petry don-petry enabled auto-merge (squash) April 28, 2026 13:54
@don-petry don-petry merged commit 3951a35 into main Apr 28, 2026
20 checks passed
@don-petry don-petry deleted the fix/compliance-audit-false-positive branch April 28, 2026 13:54
don-petry added a commit that referenced this pull request Jun 8, 2026
…ate-github check (#165)

The check incorrectly flagged petry-projects/.github/.github/workflows/ as invalid,
but this is the CORRECT pattern per GitHub's reusable workflow syntax:
- First .github = repository name
- Second .github/workflows = directory path within that repository

This check was producing false positives across all repos:
- petry-projects/TalkTerm (issues #131, #130, #129)
- petry-projects/broodly (issues #159, #158)
- petry-projects/google-app-scripts (issues #226, #225)
- petry-projects/ContentTwin (issues #111, #110)
- petry-projects/markets (issues #137, #136)
- petry-projects/bmad-bgreat-suite (issues #123, #122)

Disable the check to reduce compliance audit noise and prevent auto-issue creation
for valid patterns.

Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
don-petry added a commit that referenced this pull request Jun 10, 2026
…ate-github check (#165)

The check incorrectly flagged petry-projects/.github/.github/workflows/ as invalid,
but this is the CORRECT pattern per GitHub's reusable workflow syntax:
- First .github = repository name
- Second .github/workflows = directory path within that repository

This check was producing false positives across all repos:
- petry-projects/TalkTerm (issues #131, #130, #129)
- petry-projects/broodly (issues #159, #158)
- petry-projects/google-app-scripts (issues #226, #225)
- petry-projects/ContentTwin (issues #111, #110)
- petry-projects/markets (issues #137, #136)
- petry-projects/bmad-bgreat-suite (issues #123, #122)

Disable the check to reduce compliance audit noise and prevent auto-issue creation
for valid patterns.

Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
don-petry added a commit that referenced this pull request Jun 11, 2026
…ate-github check (#165)

The check incorrectly flagged petry-projects/.github/.github/workflows/ as invalid,
but this is the CORRECT pattern per GitHub's reusable workflow syntax:
- First .github = repository name
- Second .github/workflows = directory path within that repository

This check was producing false positives across all repos:
- petry-projects/TalkTerm (issues #131, #130, #129)
- petry-projects/broodly (issues #159, #158)
- petry-projects/google-app-scripts (issues #226, #225)
- petry-projects/ContentTwin (issues #111, #110)
- petry-projects/markets (issues #137, #136)
- petry-projects/bmad-bgreat-suite (issues #123, #122)

Disable the check to reduce compliance audit noise and prevent auto-issue creation
for valid patterns.

Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants