fix(compliance): disable false positive reusable-workflow-path-duplicate-github check#165
Conversation
…ate-github check The check incorrectly flagged petry-projects/.github/.github/workflows/ as invalid, but this is the CORRECT pattern per GitHub's reusable workflow syntax: - First .github = repository name - Second .github/workflows = directory path within that repository This check was producing false positives across all repos: - petry-projects/TalkTerm (issues #131, #130, #129) - petry-projects/broodly (issues #159, #158) - petry-projects/google-app-scripts (issues #226, #225) - petry-projects/ContentTwin (issues #111, #110) - petry-projects/markets (issues #137, #136) - petry-projects/bmad-bgreat-suite (issues #123, #122) Disable the check to reduce compliance audit noise and prevent auto-issue creation for valid patterns. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Pull request overview
Disables a compliance-audit check that incorrectly flagged the org-standard GitHub reusable workflow reference pattern petry-projects/.github/.github/workflows/... as invalid.
Changes:
- Removes the prior “duplicate
.github/” detection logic fromcheck_reusable_workflow_paths(). - Adds inline documentation explaining why the double
.github/pattern is correct for the.githubrepo per GitHub reusable workflow syntax. - Replaces the check implementation with a no-op
return 0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Reference: https://docs.github.com/en/actions/using-workflows/reusing-workflows | ||
| # Example: uses: petry-projects/.github/.github/workflows/claude-code-reusable.yml@v1 | ||
| check_reusable_workflow_paths() { | ||
| local repo="$1" |
There was a problem hiding this comment.
check_reusable_workflow_paths now declares local repo="$1" but never uses it (the function immediately returns). ShellCheck will flag this as an unused variable (SC2034), which can fail CI. Remove the local assignment, or reference the value (e.g., via a no-op like : "$1") while keeping the signature.
| local repo="$1" | |
| : "$1" |
…ate-github check (#165) The check incorrectly flagged petry-projects/.github/.github/workflows/ as invalid, but this is the CORRECT pattern per GitHub's reusable workflow syntax: - First .github = repository name - Second .github/workflows = directory path within that repository This check was producing false positives across all repos: - petry-projects/TalkTerm (issues #131, #130, #129) - petry-projects/broodly (issues #159, #158) - petry-projects/google-app-scripts (issues #226, #225) - petry-projects/ContentTwin (issues #111, #110) - petry-projects/markets (issues #137, #136) - petry-projects/bmad-bgreat-suite (issues #123, #122) Disable the check to reduce compliance audit noise and prevent auto-issue creation for valid patterns. Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
…ate-github check (#165) The check incorrectly flagged petry-projects/.github/.github/workflows/ as invalid, but this is the CORRECT pattern per GitHub's reusable workflow syntax: - First .github = repository name - Second .github/workflows = directory path within that repository This check was producing false positives across all repos: - petry-projects/TalkTerm (issues #131, #130, #129) - petry-projects/broodly (issues #159, #158) - petry-projects/google-app-scripts (issues #226, #225) - petry-projects/ContentTwin (issues #111, #110) - petry-projects/markets (issues #137, #136) - petry-projects/bmad-bgreat-suite (issues #123, #122) Disable the check to reduce compliance audit noise and prevent auto-issue creation for valid patterns. Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
…ate-github check (#165) The check incorrectly flagged petry-projects/.github/.github/workflows/ as invalid, but this is the CORRECT pattern per GitHub's reusable workflow syntax: - First .github = repository name - Second .github/workflows = directory path within that repository This check was producing false positives across all repos: - petry-projects/TalkTerm (issues #131, #130, #129) - petry-projects/broodly (issues #159, #158) - petry-projects/google-app-scripts (issues #226, #225) - petry-projects/ContentTwin (issues #111, #110) - petry-projects/markets (issues #137, #136) - petry-projects/bmad-bgreat-suite (issues #123, #122) Disable the check to reduce compliance audit noise and prevent auto-issue creation for valid patterns. Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>



Summary
Disables a false-positive compliance audit check that incorrectly flags the correct GitHub reusable workflow reference pattern.
Issue: The compliance audit was flagging
petry-projects/.github/.github/workflows/...as incorrectRoot cause: The check didn't account for GitHub's reusable workflow syntax where the first segment is the repo name and the second is the path within that repo
Solution: Disable the check and document why the double
.github/pattern is correct per org standardsAffected Repositories
This fix prevents false-positive compliance issues across 6 repos:
Changes
check_reusable_workflow_paths()inscripts/compliance-audit.shReference
GitHub Reusable Workflows: https://docs.github.com/en/actions/using-workflows/reusing-workflows
Correct pattern:
uses: petry-projects/.github/.github/workflows/workflow-name.yml@v1