chore(dev-lead): retire the legacy `claude` issue-trigger label by don-petry · Pull Request #444 · petry-projects/.github-private

don-petry · 2026-06-06T13:56:55Z

Summary

dev-lead historically accepted both dev-lead and claude labels on issues:labeled, with claude kept as backward-compat from the retired claude.yml workflow (deprecated 2026-05). We're removing the claude label org-wide, so the classifier now routes only the dev-lead label to the issue intent. A claude-labeled issue is skipped like any other non-trigger label.

Changes

scripts/dev-lead-intent.sh — dev-lead|claude) → dev-lead) (+ comment).
tests/dev-lead/unit/test_intent_issue.bats — the backward-compat test now asserts claude → skip.
docs/dev-lead/spec.md — issue intent triggers on dev-lead only.

Scope notes

The @claude trigger phrase (TRIGGER_PHRASES) is intentionally unaffected — this is about the issue label, not @mentions.
docs/dev-lead/implementation-plan.md is a point-in-time planning doc and is left as a historical record.

Companion / ordering

Pairs with petry-projects/.github#400, which migrates the compliance audit to create/cycle the dev-lead label and ships the one-time runtime migration (re-label existing open claude issues → dev-lead, then delete the claude label). Recommended order: run the runtime migration (so open issues gain dev-lead) before/with merging this, so no open issue is left only-claude during the cutover.

Verification

shellcheck -x scripts/dev-lead-intent.sh clean
Full dev-lead unit suite: 223/223 pass, 0 failures (incl. the updated claude → skip test).

🤖 Generated with Claude Code

dev-lead historically accepted both `dev-lead` and `claude` labels on issues:labeled, with `claude` kept as backward-compat from the retired claude.yml workflow. We are removing the `claude` label org-wide, so the classifier now routes only the `dev-lead` label to the `issue` intent; a `claude`-labeled issue is skipped like any other non-trigger label. - dev-lead-intent.sh: `dev-lead|claude)` → `dev-lead)`. - test_intent_issue.bats: the backward-compat test now asserts `claude` → skip. - spec.md: issue intent triggers on `dev-lead` only. Companion to petry-projects/.github#400, which migrates the compliance audit to create/cycle the `dev-lead` label and ships the one-time runtime migration (re-label existing `claude` issues, then delete the `claude` label). Note: the `@claude` trigger *phrase* (TRIGGER_PHRASES) is unaffected — this change is only about the issue *label*. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

coderabbitai · 2026-06-06T13:57:02Z

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 51 minutes and 26 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: a9124a42-0a49-4dec-86a7-ee05929446eb

📥 Commits

Reviewing files that changed from the base of the PR and between 5f8ad45 and 81d255b.

📒 Files selected for processing (3)

docs/dev-lead/spec.md
scripts/dev-lead-intent.sh
tests/dev-lead/unit/test_intent_issue.bats

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/remove-claude-label-trigger

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist

Code Review

This pull request retires the legacy claude label, leaving only the dev-lead label to trigger the issue intent. This change is applied across the documentation, the intent-parsing script, and the unit tests. A review comment suggests simplifying the intent label string in scripts/dev-lead-intent.sh to a static string since variable expansion is no longer necessary.

donpetry-bot · 2026-06-06T14:02:34Z

Sign in to view

-      dev-lead|claude)
+      dev-lead)
        context=$(printf '{"issue_number":%s}' "${issue_number:-0}")
        emit_intent "issue" "issue-labeled-${label_name}" "$context"


the variable gives flexiblity, keep as is

sonarqubecloud · 2026-06-06T13:57:40Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

Pull request overview

This PR retires the legacy claude issue label trigger for the dev-lead event classifier, aligning runtime behavior, unit tests, and the dev-lead spec with the org-wide shift to dev-lead as the sole issue-label trigger.

Changes:

Update dev-lead-intent.sh to route issues:labeled to issue intent only when the label is dev-lead (all other labels now skip).
Adjust the unit test to assert claude-labeled issues now produce skip.
Update the dev-lead spec to document dev-lead as the only issue-label trigger.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
tests/dev-lead/unit/test_intent_issue.bats	Updates backward-compat test to validate `claude` label now results in `skip`.
scripts/dev-lead-intent.sh	Removes `claude` from the `issues:labeled` trigger label set; updates intent documentation comment accordingly.
docs/dev-lead/spec.md	Updates spec mapping + intent definition to reflect `dev-lead` as the sole issue-label trigger.

  export GITHUB_EVENT_NAME="issues"
  export GITHUB_EVENT_PATH="$FIXTURES_DIR/issues_labeled_claude.json"



dev-lead historically accepted both `dev-lead` and `claude` labels on issues:labeled, with `claude` kept as backward-compat from the retired claude.yml workflow. We are removing the `claude` label org-wide, so the classifier now routes only the `dev-lead` label to the `issue` intent; a `claude`-labeled issue is skipped like any other non-trigger label. - dev-lead-intent.sh: `dev-lead|claude)` → `dev-lead)`. - test_intent_issue.bats: the backward-compat test now asserts `claude` → skip. - spec.md: issue intent triggers on `dev-lead` only. Companion to petry-projects/.github#400, which migrates the compliance audit to create/cycle the `dev-lead` label and ships the one-time runtime migration (re-label existing `claude` issues, then delete the `claude` label). Note: the `@claude` trigger *phrase* (TRIGGER_PHRASES) is unaffected — this change is only about the issue *label*. Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings June 6, 2026 13:56

Copilot started reviewing on behalf of don-petry June 6, 2026 13:57 View session

gemini-code-assist Bot reviewed Jun 6, 2026

View reviewed changes

Copilot AI reviewed Jun 6, 2026

View reviewed changes

Comment thread tests/dev-lead/unit/test_intent_issue.bats

Comment on lines 57 to 59

export GITHUB_EVENT_NAME="issues"

export GITHUB_EVENT_PATH="$FIXTURES_DIR/issues_labeled_claude.json"

don-petry merged commit e98b141 into main Jun 6, 2026
30 checks passed

don-petry deleted the chore/remove-claude-label-trigger branch June 6, 2026 14:03

github-actions Bot mentioned this pull request Jun 20, 2026

petry-projects — workflow failures detected 2026-06-20 #831

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(dev-lead): retire the legacy `claude` issue-trigger label#444

chore(dev-lead): retire the legacy `claude` issue-trigger label#444
don-petry merged 1 commit into
mainfrom
chore/remove-claude-label-trigger

don-petry commented Jun 6, 2026

Uh oh!

coderabbitai Bot commented Jun 6, 2026

Review limit reached

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

This comment was marked as resolved.

Uh oh!

donpetry-bot Jun 6, 2026

Uh oh!

sonarqubecloud Bot commented Jun 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		export GITHUB_EVENT_NAME="issues"
		export GITHUB_EVENT_PATH="$FIXTURES_DIR/issues_labeled_claude.json"

Uh oh!

Conversation

don-petry commented Jun 6, 2026

Summary

Changes

Scope notes

Companion / ordering

Verification

Uh oh!

coderabbitai Bot commented Jun 6, 2026

Review limit reached

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

This comment was marked as resolved.

Uh oh!

donpetry-bot Jun 6, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jun 6, 2026

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants