Revert redundant internal & fileprivate accessibility analysis#1038
Merged
Conversation
After further testing, I identified some significant issues with the internal analysis. * Applying `internal` explicitly to some declarations causes an incorrect result (e.g., initializers, overrides, protocol conformances). * The README states that analysis also applies to declarations that are implicitly internal, yet this is not the case. Enabling this highlights many false-positives.
Contributor
|
@ileitch I will try to dig into this and get these fixed, but do you have any specific problematic examples that you ran across? I have been using this branch for months now so I'm surprised there would be issues. |
Contributor
Author
If you tweak |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After further testing, I identified some significant issues with the internal analysis.
internalexplicitly to some declarations causes an incorrect result (e.g., initializers, overrides, protocol conformances).