Fix appendChild error before DOM constructed completely#1
Merged
Conversation
Member
|
아아아아.... 이게 문제였군요 세상에 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
manifest - content_script의 run_at이
document_start인 경우 DOM이 완성되지 않아 body에 appendChild 하는 동작이 에러를 유발합니다.따라서 https://github.com/SafetyCulture/grpc-web-devtools/blob/02eab1583b01e7ef7e906a560ae27662a913d25a/public/content-script.js#L110 를 참고하여 해결하였습니다.