fix: file extension restriction doesn't check for dot#16426
Open
timakai wants to merge 1 commit intopayloadcms:mainfrom
Open
fix: file extension restriction doesn't check for dot#16426timakai wants to merge 1 commit intopayloadcms:mainfrom
timakai wants to merge 1 commit intopayloadcms:mainfrom
Conversation
Current impl. checks extension without dot. We need to check the dot in case of files without an extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add a dot
.in front of the checked extension before validating.Why?
The current file restriction checker checks for extensions by checking the end of the filename.
It does not check if a dot is present, which gives problems with files that have no extension at all.
I uploaded a file with the name
0a621d9d1aa24f8ca3a5fbd523f6a24174061deb(a md5 hash). This file triggered thedebrestriction because it ended indeb.How?
Before:
After: