fix(ui): skip admin.condition checks in bulk edit#16387
Open
harshdhankhar11 wants to merge 1 commit intopayloadcms:mainfrom
Open
fix(ui): skip admin.condition checks in bulk edit#16387harshdhankhar11 wants to merge 1 commit intopayloadcms:mainfrom
harshdhankhar11 wants to merge 1 commit intopayloadcms:mainfrom
Conversation
Author
|
Opened this PR for #16336. I’ve also added regression coverage for the bulk edit flow. |
Author
|
Hey folks @JarrodMFlesch @jacobsfletch @AlessioGr , I put up a fix for the bulk-edit admin.condition bug (#16387) with test coverage. Just waiting on a workflow approval to get the CI green!" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16336
Summary
This PR fixes an issue where fields with
admin.conditionappear in the bulk edit field selector but are silently hidden after selection.Problem
In the bulk edit flow, selected fields can be rendered without meaningful sibling document state. Because of that,
admin.conditionmay evaluate tofalse, which hides fields that the user explicitly selected for bulk editing.Fix
admin.conditionchecks in the bulk edit flowadmin.conditionbehavior outside bulk editTesting
admin.conditionare silently hidden in bulk edit #16336