RHCLOUD-34195 Updates to Ansible logo by aferd · Pull Request #312 · patternfly/react-component-groups

aferd · 2024-09-04T20:18:20Z

closes #221
https://issues.redhat.com/browse/RHCLOUD-34195

Bumps [@octokit/plugin-paginate-rest](https://github.com/octokit/plugin-paginate-rest.js) from 11.3.0 to 11.3.3. - [Release notes](https://github.com/octokit/plugin-paginate-rest.js/releases) - [Commits](octokit/plugin-paginate-rest.js@v11.3.0...v11.3.3) --- updated-dependencies: - dependency-name: "@octokit/plugin-paginate-rest" dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@types/bonjour](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/bonjour) from 3.5.10 to 3.5.13. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/bonjour) --- updated-dependencies: - dependency-name: "@types/bonjour" dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [binary-extensions](https://github.com/sindresorhus/binary-extensions) from 2.2.0 to 2.3.0. - [Release notes](https://github.com/sindresorhus/binary-extensions/releases) - [Commits](sindresorhus/binary-extensions@v2.2.0...v2.3.0) --- updated-dependencies: - dependency-name: binary-extensions dependency-type: indirect update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@octokit/request](https://github.com/octokit/request.js) from 9.1.1 to 9.1.3. - [Release notes](https://github.com/octokit/request.js/releases) - [Commits](octokit/request.js@v9.1.1...v9.1.3) --- updated-dependencies: - dependency-name: "@octokit/request" dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [pirates](https://github.com/danez/pirates) from 4.0.5 to 4.0.6. - [Release notes](https://github.com/danez/pirates/releases) - [Commits](danez/pirates@v4.0.5...v4.0.6) --- updated-dependencies: - dependency-name: pirates dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@types/aria-query](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/aria-query) from 5.0.1 to 5.0.4. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/aria-query) --- updated-dependencies: - dependency-name: "@types/aria-query" dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@types/http-proxy](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/http-proxy) from 1.17.11 to 1.17.15. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/http-proxy) --- updated-dependencies: - dependency-name: "@types/http-proxy" dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@types/json-schema](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/json-schema) from 7.0.12 to 7.0.15. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/json-schema) --- updated-dependencies: - dependency-name: "@types/json-schema" dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [caniuse-lite](https://github.com/browserslist/caniuse-lite) from 1.0.30001649 to 1.0.30001653. - [Commits](browserslist/caniuse-lite@1.0.30001649...1.0.30001653) --- updated-dependencies: - dependency-name: caniuse-lite dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…it/plugin-paginate-rest-11.3.3

…/bonjour-3.5.13

…y-extensions-2.3.0

…it/request-9.1.3

…es-4.0.6

…/aria-query-5.0.4

…/http-proxy-1.17.15

…/json-schema-7.0.15

…r-5.7.2

…se-lite-1.0.30001653

patternfly-build · 2024-09-04T20:19:30Z

Preview: https://react-component-groups-pr-component-groups-312.surge.sh

A11y report: https://react-component-groups-pr-component-groups-312-a11y.surge.sh

packages/module/src/Ansible/Ansible.tsx

packages/module/src/Ansible/rhaap-icon.tsx

fhlavac · 2024-09-06T08:16:57Z

Just a few comments, overall it looks great! 🙂
Can you please also update the test cases when you are done? Thank you

kaylachumley · 2024-09-06T14:49:57Z

Hey @fhlavac Do you suggest we keep or remove the unsupported state? If we keep it then it'll need to pf-t--global--icon--color--disabled applied to the icon

Also it looks like the redhat AAP logo needs to be added in still

aferd · 2024-09-06T15:12:42Z

Hey @fhlavac Do you suggest we keep or remove the unsupported state? If we keep it then it'll need to pf-t--global--icon--color--disabled applied to the icon

Also it looks like the redhat AAP logo needs to be added in still

I forgot to update the example file, it should be there now.

fhlavac · 2024-09-09T08:14:34Z

Hey @fhlavac Do you suggest we keep or remove the unsupported state? If we keep it then it'll need to pf-t--global--icon--color--disabled applied to the icon

I just suggested making the unsupported state available for both icons, now it is available only for the standalone Ansible, not Red Hat one.

packages/module/src/Ansible/Ansible.tsx

packages/module/src/Ansible/Ansible.test.tsx

packages/module/src/Ansible/Ansible.tsx

fhlavac · 2024-09-20T07:02:54Z

@kaylachumley do we have any update on how/if to change the RHAP disabled state colors?

Dismissing since we need an answer on the RHAAP disabled state colors before merging.

packages/module/src/Ansible/Ansible.tsx

fhlavac · 2024-09-20T13:54:30Z

@aferd from what @kaylachumley found out it looks like there will be no RHAAP unsupported state for now, so we should be good.

fhlavac · 2024-09-24T11:14:41Z

@aferd I've resolved the conflicts, just we may need the snapshots to be updated

dependabot bot and others added 21 commits August 27, 2024 17:12

Merge pull request #290 from patternfly/dependabot/npm_and_yarn/octok…

dc1de5d

…it/plugin-paginate-rest-11.3.3

Merge pull request #291 from patternfly/dependabot/npm_and_yarn/types…

c5d380e

…/bonjour-3.5.13

Merge pull request #292 from patternfly/dependabot/npm_and_yarn/binar…

2bf5d0f

…y-extensions-2.3.0

Merge pull request #293 from patternfly/dependabot/npm_and_yarn/octok…

434aa10

…it/request-9.1.3

Merge pull request #294 from patternfly/dependabot/npm_and_yarn/pirat…

1f9a591

…es-4.0.6

Merge pull request #295 from patternfly/dependabot/npm_and_yarn/types…

2bfcaa7

…/aria-query-5.0.4

Merge pull request #296 from patternfly/dependabot/npm_and_yarn/types…

e099dd1

…/http-proxy-1.17.15

Merge pull request #297 from patternfly/dependabot/npm_and_yarn/types…

8b474dc

…/json-schema-7.0.15

Merge pull request #298 from patternfly/dependabot/npm_and_yarn/semve…

b682e9b

…r-5.7.2

Merge pull request #299 from patternfly/dependabot/npm_and_yarn/caniu…

793f50e

…se-lite-1.0.30001653

init ansible icon updates

867c3d0

aferd marked this pull request as draft September 4, 2024 20:20

aferd added 2 commits September 4, 2024 16:36

show icon

3a0ca5c

fix docs and logic

073d684

aferd changed the title ~~RHCLOUD-34195~~ RHCLOUD-34195 Updates to Ansible logo Sep 5, 2024

aferd and others added 4 commits September 5, 2024 11:30

lint fix

549029d

add icon back

0d5ee7d

rhaap icon update

ffdca70

lint fix

4283e3d

fhlavac reviewed Sep 6, 2024

View reviewed changes

packages/module/src/Ansible/Ansible.tsx Outdated Show resolved Hide resolved

fhlavac reviewed Sep 6, 2024

View reviewed changes

packages/module/src/Ansible/rhaap-icon.tsx Outdated Show resolved Hide resolved

add suggested changes

30fe5d5

aferd changed the base branch from main to v6 September 6, 2024 14:41

update examples

4dc1758

aferd and others added 3 commits September 12, 2024 11:49

Merge branch 'v6' into RHCLOUD-34195

b84156e

update prop and disabled color

50df64a

fix color

8d8030f

fhlavac reviewed Sep 16, 2024

View reviewed changes

packages/module/src/Ansible/Ansible.tsx Outdated Show resolved Hide resolved

fhlavac reviewed Sep 16, 2024

View reviewed changes

packages/module/src/Ansible/Ansible.tsx Outdated Show resolved Hide resolved

fhlavac reviewed Sep 16, 2024

View reviewed changes

packages/module/src/Ansible/Ansible.test.tsx Outdated Show resolved Hide resolved

fhlavac reviewed Sep 16, 2024

View reviewed changes

packages/module/src/Ansible/Ansible.tsx Outdated Show resolved Hide resolved

dlabaj previously approved these changes Sep 18, 2024

View reviewed changes

aferd added 2 commits September 19, 2024 11:24

add title and ouiaID to RHAAP icon

6d720c4

update snapshot

6d5d936

fhlavac reviewed Sep 20, 2024

View reviewed changes

packages/module/src/Ansible/Ansible.tsx Outdated Show resolved Hide resolved

aferd added 2 commits September 23, 2024 08:56

remove unsupported state from rhaap

ca13617

update snapshot

437ad78

fhlavac approved these changes Sep 24, 2024

View reviewed changes

Merge branch 'main' into RHCLOUD-34195

80add95

aferd closed this by deleting the head repository Sep 24, 2024

aferd mentioned this pull request Sep 24, 2024

RHCLOUD-34195 Ansible logo updates #354

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RHCLOUD-34195 Updates to Ansible logo#312

RHCLOUD-34195 Updates to Ansible logo#312
aferd wants to merge 39 commits intopatternfly:mainfrom
aferd:RHCLOUD-34195

aferd commented Sep 4, 2024 •

edited by fhlavac

Loading

Uh oh!

patternfly-build commented Sep 4, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fhlavac commented Sep 6, 2024

Uh oh!

kaylachumley commented Sep 6, 2024

Uh oh!

aferd commented Sep 6, 2024

Uh oh!

fhlavac commented Sep 9, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fhlavac commented Sep 20, 2024

Uh oh!

Uh oh!

fhlavac commented Sep 20, 2024

Uh oh!

fhlavac commented Sep 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

aferd commented Sep 4, 2024 • edited by fhlavac Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patternfly-build commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fhlavac commented Sep 6, 2024

Uh oh!

kaylachumley commented Sep 6, 2024

Uh oh!

aferd commented Sep 6, 2024

Uh oh!

fhlavac commented Sep 9, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fhlavac commented Sep 20, 2024

Uh oh!

Uh oh!

fhlavac commented Sep 20, 2024

Uh oh!

fhlavac commented Sep 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

aferd commented Sep 4, 2024 •

edited by fhlavac

Loading

patternfly-build commented Sep 4, 2024 •

edited

Loading