Margin and fontSize alignment of TagCount#225
Conversation
| tagText: { | ||
| marginLeft: 10 | ||
| marginLeft: 6, | ||
| fontSize: 14 |
There was a problem hiding this comment.
| fontSize: 14 | |
| fontSize: 'var(--pf-v5-global--FontSize--sm') |
|
|
||
| tagText: { | ||
| marginLeft: 10 | ||
| marginLeft: 6, |
There was a problem hiding this comment.
this one could be replaced with a variable as well
the closest is probably "--pf-v5-global--spacer--sm" 0.5rem.
@kaylachumley according to PF rules, do you think we should go with hardcoded 6px or that variable? Thank you
|
@jiridostal looks good, thank you. Let me just check quickly on the variables. It's preferred to use them instead of hardcoded values |
|
Let's use the variable over the hard coded values so all changes can be adopted with future variable updates! Thanks! |
|
Also, The tag count styling seems to be a little off, not sure if this is still in the works with another issue on text and icon color |
|
@kaylachumley yeah, the remaining issues will be tracked separately. Thank you! |
5 participants
RHINENG-7746
The tag number and icon seems to be misaligned and font-size is off in the context of surrounding content.
Before:
fontSize: 16px
margin: 10px
After:
fontSize: 14px
margin: 6px
Any changes or improvements to this PR are welcome.