Conversation
fhlavac
requested review from
Hyperkid123,
andrew-ronaldson,
karelhala and
nicolethoen
|
|
||
| ### Bulk select with all option | ||
|
|
||
| To display an option for seleting all data at once, pass `canSelectAll` flag together with `totalCount` of data entries. You can also remove the page select option by setting `isDataPaginated` to `false`, |
There was a problem hiding this comment.
just a typo on seleting (selecting)
...module/patternfly-docs/content/extensions/component-groups/examples/BulkSelect/BulkSelect.md
Outdated
Show resolved
Hide resolved
| splitButtonOptions={{ | ||
| items: [ | ||
| <MenuToggleCheckbox | ||
| ouiaId={`${ouiaId}-checkbox`} |
There was a problem hiding this comment.
I think we might want to provide some sort of MenuToggleCheckboxProps. We can omit the onChange and isChecked props, but the rest should be configurable.
| items: [ | ||
| <MenuToggleCheckbox | ||
| ouiaId={`${ouiaId}-checkbox`} | ||
| id={BulkSelectValue.page} |
There was a problem hiding this comment.
Can't use constant like this. There will be ID errors with multiple bulk selects on a page.
fhlavac
force-pushed
the
bulk
branch
3 times, most recently
from
789c971 to
6674c11
Compare
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
I notice that when you use a keyboard to select an item from the menu, the focus then gets lost. I believe the focus should return to the toggle after an item is selected.
|
@nicolethoen Oh yeah, I've added the PF flag for that thing. The problem is that it does not work for the splitButtonOptions. As far as I see correctly in the PF MenuToggle implementation, the ref is being passed to the |
|
@Hyperkid123 @andrew-ronaldson @nicolethoen do you think we can get it to pre-release as it is, so we can start using it in DataView development? The focus thing will be fixed as a follow-up depending on the response from PF devs. |
5 participants
RHCLOUD-33144
Added BulkSelect component to component groups with docs and tests