feat(Navigation): Penta updates for nav#9948
Merged
mattnolting merged 4 commits intopatternfly:v6from Jan 16, 2024
Merged
Conversation
tlabaj
requested review from
a team,
kmcfaul,
mattnolting and
wise-king-sullyman
and removed request for
a team
Collaborator
|
Preview: https://patternfly-react-pr-9948.surge.sh A11y report: https://patternfly-react-pr-9948-a11y.surge.sh |
This was referenced Jan 9, 2024
wise-king-sullyman
approved these changes
Jan 12, 2024
Collaborator
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
The horizontal subnav scroll buttons seem to be showing when they shouldn't, but other than that everything looks great to me!
Contributor
Author
|
@wise-king-sullyman open this follow up issue. #9977 |
mattnolting
reviewed
Jan 16, 2024
Contributor
mattnolting
left a comment
mattnolting
left a comment
There was a problem hiding this comment.
Looks like you have an extra divider in the expandable example, other than that, great work!
kmcfaul
approved these changes
Jan 16, 2024
Contributor
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
LGTM.
The flyout menu still uses the old styling but I think that's a part of Menu's css and not Nav's, through the pf-m-nav modifier on the Menu right? @mcoker / @mattnolting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #9943
Also made updates to the Page component. There were references to tertiary nav. Updated them to refer to horizontal subnav.