feat(Page): Added secondary variant styling for Penta work#9848
Merged
tlabaj merged 2 commits intopatternfly:v6from Dec 6, 2023
Merged
feat(Page): Added secondary variant styling for Penta work#9848tlabaj merged 2 commits intopatternfly:v6from
tlabaj merged 2 commits intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-9848.surge.sh A11y report: https://patternfly-react-pr-9848-a11y.surge.sh |
thatblindgeye
force-pushed
the
iss9808_pagePenta
branch
from
3fab0f8 to
ca61d02
Compare
thatblindgeye
requested review from
a team,
kmcfaul,
srambach and
tlabaj
and removed request for
a team
tlabaj
requested review from
a team and
mmenestr
and removed request for
a team
tlabaj
requested changes
Dec 6, 2023
Contributor
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
Can you update the examples to demonstrate this similar to what is done in cores examples
https://pf6.patternfly.org/components/page#vertical-nav
https://pf6.patternfly.org/components/page#horizontal-nav
https://pf6.patternfly.org/components/page#main-section-variations
kmcfaul
approved these changes
Dec 6, 2023
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #9808
We probably want to remove the deprecated tertiary nav Page example whenever we also remove the React deprecated tab.
Additional issues: