chore(Chip): updated unit tests#9572
Merged
tlabaj merged 5 commits intopatternfly:mainfrom Oct 27, 2023
Merged
Conversation
thatblindgeye
commented
Sep 6, 2023
| const Component = component as any; | ||
| return ( | ||
| <Component | ||
| {...(this.props.textMaxWidth && { |
Contributor
Author
There was a problem hiding this comment.
This was causing a textmaxwidth attribute to be rendered due to the spread ...props on line 154
Collaborator
|
Preview: https://patternfly-react-pr-9572.surge.sh A11y report: https://patternfly-react-pr-9572-a11y.surge.sh |
thatblindgeye
force-pushed
the
iss9530_chip_test_update
branch
from
8dfb8b9 to
b361848
Compare
wise-king-sullyman
requested changes
Oct 13, 2023
Collaborator
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Really great work on this! I do have a handful of questions and a couple of requests though.
packages/react-core/src/components/Chip/__tests__/Chip.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Chip/__tests__/Chip.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Chip/__tests__/Chip.test.tsx
Outdated
Show resolved
Hide resolved
thatblindgeye
force-pushed
the
iss9530_chip_test_update
branch
2 times, most recently
from
8a8a528 to
a581641
Compare
thatblindgeye
force-pushed
the
iss9530_chip_test_update
branch
from
a581641 to
ef8359a
Compare
packages/react-core/src/components/Chip/__tests__/Chip.test.tsx
Outdated
Show resolved
Hide resolved
thatblindgeye
force-pushed
the
iss9530_chip_test_update
branch
from
ef8359a to
c7b165e
Compare
tlabaj
approved these changes
Oct 27, 2023
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #9530
Added integration test to check that tooltipPosition is passed to Tooltip properly
Additional issues: