docs(TimePicker): updated examples to TypeScript#9430
Merged
tlabaj merged 2 commits intopatternfly:mainfrom Aug 14, 2023
Merged
docs(TimePicker): updated examples to TypeScript#9430tlabaj merged 2 commits intopatternfly:mainfrom
tlabaj merged 2 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-9430.surge.sh A11y report: https://patternfly-react-pr-9430-a11y.surge.sh |
kmcfaul
approved these changes
Aug 1, 2023
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Just a nit to add "TimePicker" to the beginning of each export. Though if we want to stray away from including the component name that could make sense
thatblindgeye
approved these changes
Aug 7, 2023
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
* docs(TimePicker): updated examples to TypeScript * docs(TimePicker): added TimePicker to exported var names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #9352
Additional issues:
Convenience link: https://patternfly-react-pr-9430.surge.sh/components/date-and-time/time-picker