Skip to content

chore(Alert): updated tests to new standards #8114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 5 commits into from
Sep 29, 2022
Merged

chore(Alert): updated tests to new standards #8114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5364117
chore(Alert): updated tests to new standards
wise-king-sullyman Jul 7, 2022
0516cea
fixed small bugs in Alert sub-components
wise-king-sullyman Sep 28, 2022
2751ae7
update sanity check test to match current approach
wise-king-sullyman Sep 28, 2022
47db8fe
remove eslint-disable that's no longer needed
wise-king-sullyman Sep 28, 2022
3e98105
fixed typos
wise-king-sullyman Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-core/src/components/Alert/AlertActionCloseButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ export interface AlertActionCloseButtonProps extends ButtonProps {
}

export const AlertActionCloseButton: React.FunctionComponent<AlertActionCloseButtonProps> = ({
// eslint-disable-next-line @typescript-eslint/no-unused-vars
className = '',
className,
onClose = () => undefined as any,
'aria-label': ariaLabel = '',
variantLabel,
Expand All @@ -28,6 +27,7 @@ export const AlertActionCloseButton: React.FunctionComponent<AlertActionCloseBut
variant={ButtonVariant.plain}
onClick={onClose}
aria-label={ariaLabel === '' ? `Close ${variantLabel || alertVariantLabel} alert: ${title}` : ariaLabel}
className={className}
{...props}
>
<TimesIcon />
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/Alert/AlertToggleExpandButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ export interface AlertToggleExpandButtonProps extends ButtonProps {
}

export const AlertToggleExpandButton: React.FunctionComponent<AlertToggleExpandButtonProps> = ({
'aria-label': ariaLabel,
'aria-label': ariaLabel = '',
variantLabel,
onToggleExpand,
isExpanded,
isExpanded = false,
...props
}: AlertToggleExpandButtonProps) => {
const { title, variantLabel: alertVariantLabel } = React.useContext(AlertContext);
Expand Down
Loading